codegen: Add an option to skip comment generation. #444
Conversation
| @@ -1007,8 +1011,10 @@ impl CodeGenerator for CompInfo { | |||
| }; | |||
|
|
|||
| let mut attrs = vec![]; | |||
| if let Some(comment) = field.comment() { | |||
| attrs.push(attributes::doc(comment)); | |||
| if ctx.options().generate_comments { | |||
There was a problem hiding this comment.
This is a whole lot of copy paste... What if we made Item::comment and Field::comment take the context and check themselves? The earlier we push this check, we could even potentially avoid keeping the comments around in memory.
I would be fine with landing this code now and investigating this later, but if you do want to land the code now, please file an issue and maybe mark it as a good first bug to attract new contributors.
There was a problem hiding this comment.
That's right, but I thought that the alternative would be less readable? Anyway, will file.
| @@ -1,6 +1,6 @@ | |||
| [root] | |||
| name = "bindgen" | |||
| version = "0.20.2" | |||
| version = "0.20.3" | |||
There was a problem hiding this comment.
This should ideally be part of the previous commit.
| /// Whether to whitelist types recursively or not. Defaults to true. | ||
| /// | ||
| /// See https://github.com/servo/rust-bindgen/issues/429 for different use | ||
| /// cases for this. |
There was a problem hiding this comment.
I think we should elaborate the use cases here: one shouldn't have to jump from the rustdocs to a random github issue to understand why a method exists and to figure out if they should use it or not.
This is mostly a work around rust-lang#426, until we implement the proper fix.
|
@bors-servo r=fitzgen |
|
📌 Commit 78e425f has been approved by |
|
☀️ Test successful - status-travis |
|
This is much appreciated. Thanks! |
This is mostly a work around #426,
until we implement the proper fix.
r? @fitzgen