Can't compile with recent nightly

[killercup]

Maybe you already know this, but it couldn't find an issue. (I'm compiling this project but it shouldn't matter.)

$ cargo run --features "dev" --release
   Compiling clippy v0.0.4 (https://github.com/Manishearth/rust-clippy.git#62f0fe0c)
/Users/pascal/.multirust/toolchains/nightly/cargo/git/checkouts/rust-clippy-2d80226e8d82d2cc/master/src/ptr_arg.rs:30:11: 30:39 error: this pattern has 5 fields, but the corresponding variant has 6 fields [E0023]
/Users/pascal/.multirust/toolchains/nightly/cargo/git/checkouts/rust-clippy-2d80226e8d82d2cc/master/src/ptr_arg.rs:30       if let &ItemFn(ref decl, _, _, _, _) = &item.node {
                                                                                                                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
note: in expansion of if let expansion
/Users/pascal/.multirust/toolchains/nightly/cargo/git/checkouts/rust-clippy-2d80226e8d82d2cc/master/src/ptr_arg.rs:30:3: 32:4 note: expansion site
/Users/pascal/.multirust/toolchains/nightly/cargo/git/checkouts/rust-clippy-2d80226e8d82d2cc/master/src/ptr_arg.rs:30:11: 30:39 help: run `rustc --explain E0023` to see a detailed explanation
error: aborting due to previous error
Could not compile `clippy`.

To learn more, run the command again with --verbose.

$ rustc --version --verbose
rustc 1.2.0-nightly (7c4eedc21 2015-05-25) (built 2015-05-24)
binary: rustc
commit-hash: 7c4eedc21e609446671cc838d08473421917c353
commit-date: 2015-05-25
build-date: 2015-05-24
host: x86_64-apple-darwin
release: 1.2.0-nightly

[llogiq]

Yep, that's the problem with using unstable APIs. All breakage that results is ours to fix.

[killercup]

the problem

The challenge! :)

The signature of ItemFn was changed in rust-lang/rust@af37957. Looks like this can be fixed with an additional , _ (the third parameter now defines Constness).

[llogiq]

Yes, but I think we should use conditional compilation to avoid breaking previous builds.

[Manishearth]

Nah; lockfiles handle that already. We should stick to nightlies and use travis to find out when we need to fix it.

[llogiq]

Ok then.