Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[unwrap_used]: Do not lint unwrapping on ! or never-like enums #11252

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

Centri3
Copy link
Member

@Centri3 Centri3 commented Jul 29, 2023

Fixes #11245

changelog: [unwrap_used]: Do not lint unwrapping on ! or never-like enums
changelog: [expect_used]: Do not lint unwrapping on ! or never-like enums

@rustbot
Copy link
Collaborator

rustbot commented Jul 29, 2023

r? @xFrednet

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 29, 2023
Copy link
Member

@xFrednet xFrednet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a nice refactoring! I have two small NITs, everything else looks good to me! You can r=me once the nits have been addressed.

clippy_lints/src/methods/unwrap_expect_used.rs Outdated Show resolved Hide resolved
clippy_lints/src/methods/unwrap_expect_used.rs Outdated Show resolved Hide resolved
@Centri3
Copy link
Member Author

Centri3 commented Aug 2, 2023

Somehow managed to put the utils function in just the right spot to cause a conflict. :D

@bors r=xFrednet

@bors
Copy link
Collaborator

bors commented Aug 2, 2023

📌 Commit 71c5413 has been approved by xFrednet

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Aug 2, 2023

⌛ Testing commit 71c5413 with merge 7af5ea1...

@bors
Copy link
Collaborator

bors commented Aug 2, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 7af5ea1 to master...

@bors bors merged commit 7af5ea1 into rust-lang:master Aug 2, 2023
4 checks passed
@Centri3 Centri3 deleted the #11245 branch August 2, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lint to check for unwrap except on Infallible error
4 participants