[unused_enumerate_index]: don't ICE on empty tuples
#11756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Manishearth (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
I'm not sure if this affects beta, looks like this only popped up right after the sync that merged today. |
|
oh right |
rustbot
removed
the
beta-nominated
|
yeah, no beta ICE, we might still want to backport the fix directly into rust-lang/rust master though :) |
Manishearth
approved these changes
Nov 3, 2023
|
@bors r+ |
|
Yeah let's backport into rust-lang/rust |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
matthiaskrgr
added
the
beta-nominated
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 21, 2023
…troalbini [beta] Clippy beta backport PR towards stable, as beta was branched a day early and I missed the notification. - rust-lang/rust-clippy#11538 - rust-lang/rust-clippy#11756 - rust-lang/rust-clippy#11760 - rust-lang/rust-clippy#11953 r? `@pietroalbini`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 21, 2023
…troalbini [beta] Clippy beta backport PR towards stable, as beta was branched a day early and I missed the notification. - rust-lang/rust-clippy#11538 - rust-lang/rust-clippy#11756 - rust-lang/rust-clippy#11760 - rust-lang/rust-clippy#11953 r? `@pietroalbini`
flip1995
added
beta-accepted
xFrednet
removed
the
beta-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11755
changelog: [
unused_enumerate_index]: don't ICE on empty tuplesI'm going to nominate for beta backport because the code that is needed to trigger this seems likely to occur in real code
@rustbot label +beta-nominated