Correctly handle closing parens in missing_backticks doc lint
#12809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Should we be worried? ^^' |
y21
reviewed
May 17, 2024
Wdym by this? |
GuillaumeGomez
force-pushed
the
missing-backticks-fix
branch
2 times, most recently
from
5a54e6b
to
344c3bc
Compare
GuillaumeGomez
force-pushed
the
missing-backticks-fix
branch
from
344c3bc
to
4f98cc6
Compare
|
Fixed it! I forgot to add the offset for the range, leading to wrong checks and invalid span. |
y21
approved these changes
May 25, 2024
|
Thanks! @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12795.
changelog: Correctly handle closing parens in
doc_markdownlint