Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split TyImplTrait into Universal and Existential #2228

Merged
merged 1 commit into from
Nov 17, 2017

Conversation

chrisvittal
Copy link
Contributor

rust-lang/rust#45918 has landed, it broke clippy due to changing the hir::Ty_ enum. This change replaces the old enum variant with the two new ones.

This fixes build after the implementation of impl Trait in argument
position lands in rustc
@chrisvittal chrisvittal reopened this Nov 17, 2017
@oli-obk
Copy link
Contributor

oli-obk commented Nov 17, 2017

lol the timing, I just manually restarted travis :D

@chrisvittal
Copy link
Contributor Author

I noticed that on the branch that rust uses this is already incorporated.

@chrisvittal chrisvittal reopened this Nov 17, 2017
@chrisvittal
Copy link
Contributor Author

Aaah, sorry. My bad. Misclicked.

@oli-obk
Copy link
Contributor

oli-obk commented Nov 17, 2017

Yea, I'm prepping a publish right now. Then I'll merge it into master.

Thanks so much for fixing clippy after your PR!

@chrisvittal
Copy link
Contributor Author

You're welcome!

@oli-obk oli-obk merged commit 0155ecf into rust-lang:master Nov 17, 2017
@chrisvittal chrisvittal deleted the impl-trait-fix branch November 17, 2017 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants