Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make most macro checks also check for desugarings #4082

Merged
merged 2 commits into from May 12, 2019

Conversation

Projects
None yet
3 participants
@Manishearth
Copy link
Member

commented May 12, 2019

We should audit the macro checks one by one and re-add in_macro. I suspect it's applicable to most of them.

fixes #4081

@Manishearth

This comment has been minimized.

Copy link
Member Author

commented May 12, 2019

I don't have a regression test in here because the issue had a proc macro, might add one later.

@Manishearth Manishearth force-pushed the Manishearth:macro-check-split branch from c063ba1 to abf6481 May 12, 2019

@oli-obk

This comment has been minimized.

Copy link
Collaborator

commented May 12, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented May 12, 2019

📌 Commit abf6481 has been approved by oli-obk

@bors

This comment has been minimized.

Copy link
Contributor

commented May 12, 2019

⌛️ Testing commit abf6481 with merge feb18c3...

bors added a commit that referenced this pull request May 12, 2019

Auto merge of #4082 - Manishearth:macro-check-split, r=oli-obk
Make most macro checks also check for desugarings

We should audit the macro checks one by one and re-add `in_macro`. I suspect it's applicable to most of them.

fixes #4081
@bors

This comment has been minimized.

Copy link
Contributor

commented May 12, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: oli-obk
Pushing feb18c3 to master...

@bors bors merged commit abf6481 into rust-lang:master May 12, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
homu Test successful
Details

bors added a commit that referenced this pull request May 12, 2019

Auto merge of #4089 - flip1995:id_conv_reg_test, r=Manishearth
Add regression test for identity_conversion FP

cc #3913 #4082 #3936

changelog: none
@Manishearth

This comment has been minimized.

Copy link
Member Author

commented May 12, 2019

oops forgot to changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.