Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To digit is some #4801

Merged
merged 4 commits into from Nov 11, 2019
Merged

To digit is some #4801

merged 4 commits into from Nov 11, 2019

Conversation

ghost
Copy link

@ghost ghost commented Nov 10, 2019

Add a lint that recommends replacing to_digit().is_some() with is_digit() on chars

changelog: Add lint to_digit_is_some

@phansch phansch added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 11, 2019
@flip1995
Copy link
Member

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 11, 2019

📌 Commit 89b966c has been approved by flip1995

@bors
Copy link
Collaborator

bors commented Nov 11, 2019

⌛ Testing commit 89b966c with merge 79d3b30...

bors added a commit that referenced this pull request Nov 11, 2019
To digit is some

Add a lint that recommends replacing `to_digit().is_some()` with `is_digit()` on `char`s

changelog: Add lint `to_digit_is_some`
@bors
Copy link
Collaborator

bors commented Nov 11, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 79d3b30 to master...

@bors bors merged commit 89b966c into rust-lang:master Nov 11, 2019
@ghost ghost deleted the to_digit_is_some branch December 26, 2019 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants