Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: keep parenthesis for suggestion in useless_conversion lint #5900

Merged
merged 1 commit into from
Aug 13, 2020

Conversation

ThibsG
Copy link
Contributor

@ThibsG ThibsG commented Aug 12, 2020

Note: this lint was previously named identity_conversion.

fixes: #4750

changelog: fix parenthesis for useless_conversion lint suggestion

@rust-highfive
Copy link

r? @phansch

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 12, 2020
@phansch
Copy link
Member

phansch commented Aug 13, 2020

@bors r+ thanks!

@bors
Copy link
Collaborator

bors commented Aug 13, 2020

📌 Commit 5634c8d has been approved by phansch

@bors
Copy link
Collaborator

bors commented Aug 13, 2020

⌛ Testing commit 5634c8d with merge fc4fd91...

@bors
Copy link
Collaborator

bors commented Aug 13, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: phansch
Pushing fc4fd91 to master...

@bors bors merged commit fc4fd91 into rust-lang:master Aug 13, 2020
@ThibsG ThibsG deleted the ParensUselessConversion4750 branch August 24, 2020 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cargo fix] identity_conversion removes parenthesis with inner expression, that needs them.
4 participants