Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added known problem to comparison_chain docs #6390

Merged
merged 1 commit into from
Nov 28, 2020
Merged

Added known problem to comparison_chain docs #6390

merged 1 commit into from
Nov 28, 2020

Conversation

pro-grammer1
Copy link
Contributor

@pro-grammer1 pro-grammer1 commented Nov 27, 2020

changelog: Added documentation to comparison_chain that explains a possible performance penalty, according to issue #5354

This is my first PR, I hope everything has been done correctly.

Fixes #5354

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ebroto (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 27, 2020
Copy link
Member

@ebroto ebroto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and welcome to Clippy!

@ebroto
Copy link
Member

ebroto commented Nov 28, 2020

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 28, 2020

📌 Commit cb6a654 has been approved by ebroto

@ebroto ebroto removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 28, 2020
@bors
Copy link
Collaborator

bors commented Nov 28, 2020

⌛ Testing commit cb6a654 with merge e42ba48...

@bors
Copy link
Collaborator

bors commented Nov 28, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: ebroto
Pushing e42ba48 to master...

@bors bors merged commit e42ba48 into rust-lang:master Nov 28, 2020
@JeromeSchmied
Copy link

If #5354 was resolved by this pr, shouldn't clippy docs be updated?
clippy docs still says:

Known problems

The match statement may be slower due to the compiler not inlining the call to cmp. See issue #5354

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

comparison_chain suggestion can be a performance regression
5 participants