Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positives on procedural macros of missing_inline_in_public_items lint #6814

Merged
merged 1 commit into from Mar 10, 2021
Merged

Conversation

ghost
Copy link

@ghost ghost commented Feb 28, 2021

Fixes #6486.

changelog: Fix false positives on procedural macros of missing_inline_in_public_items lint.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @flip1995 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 28, 2021
@flip1995
Copy link
Member

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented Mar 10, 2021

📌 Commit da3a573 has been approved by flip1995

@bors
Copy link
Collaborator

bors commented Mar 10, 2021

⌛ Testing commit da3a573 with merge 8222d48...

@bors
Copy link
Collaborator

bors commented Mar 10, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 8222d48 to master...

@bors bors merged commit 8222d48 into rust-lang:master Mar 10, 2021
@ghost ghost deleted the issue-6486 branch March 13, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing_inline_in_public_items probably doesn't make sense in crates intended for procedural macros
3 participants