Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move naive_bytecount to pedantic #6825

Merged
merged 1 commit into from
Mar 3, 2021

Conversation

djc
Copy link
Contributor

@djc djc commented Mar 2, 2021

As discussed on Zulip, current best practice is to avoid recommending
external crates. This lint is from before that was enforced. Move it
to the pedantic group to avoid enabling it by default.

https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/naive_bytecount.20suggesting.20extra.20dependency

changelog: move [naive_bytecount] to pedantic

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 2, 2021
As discussed on Zulip, current best practice is to avoid recommending
external crates. This lint is from before that was enforced. Move it
to the pedantic group to avoid enabling it by default.

https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/naive_bytecount.20suggesting.20extra.20dependency
@djc djc force-pushed the naive-bytecount-pedantic branch from 549a58b to 9e4a064 Compare March 2, 2021 13:34
@Manishearth
Copy link
Member

@bors r+

Thanks! Added a changelog entry to your PR body so this can land

@bors
Copy link
Collaborator

bors commented Mar 3, 2021

📌 Commit 9e4a064 has been approved by Manishearth

@bors
Copy link
Collaborator

bors commented Mar 3, 2021

⌛ Testing commit 9e4a064 with merge ff51964...

@bors
Copy link
Collaborator

bors commented Mar 3, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing ff51964 to master...

@bors bors merged commit ff51964 into rust-lang:master Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants