Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a false negative on needless return #7067

Merged
merged 3 commits into from
Apr 12, 2021

Conversation

TaKO8Ki
Copy link
Member

@TaKO8Ki TaKO8Ki commented Apr 12, 2021

closes #7042

changelog: fix a false negative on needless return

@rust-highfive
Copy link

r? @llogiq

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 12, 2021
@llogiq
Copy link
Contributor

llogiq commented Apr 12, 2021

Thank you! @bors r+

@bors
Copy link
Collaborator

bors commented Apr 12, 2021

📌 Commit e6c67ad has been approved by llogiq

@bors
Copy link
Collaborator

bors commented Apr 12, 2021

⌛ Testing commit e6c67ad with merge 2a96bc4...

@bors
Copy link
Collaborator

bors commented Apr 12, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing 2a96bc4 to master...

@bors bors merged commit 2a96bc4 into rust-lang:master Apr 12, 2021
@TaKO8Ki TaKO8Ki deleted the fix-false-negative-on-needless-return branch April 12, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

needless_return does not lint on async function
4 participants