Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eval_order_dependence async false positive #7174

Merged
merged 2 commits into from
May 5, 2021

Conversation

camsteffen
Copy link
Contributor

changelog: Fix [eval_order_dependence] false positive in async code

Fixes #6925

@rust-highfive
Copy link

r? @flip1995

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 5, 2021
@flip1995
Copy link
Member

flip1995 commented May 5, 2021

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented May 5, 2021

📌 Commit 7a7b8bd has been approved by flip1995

@bors
Copy link
Collaborator

bors commented May 5, 2021

⌛ Testing commit 7a7b8bd with merge 93fe356...

@bors
Copy link
Collaborator

bors commented May 5, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 93fe356 to master...

@bors bors merged commit 93fe356 into rust-lang:master May 5, 2021
@camsteffen camsteffen deleted the eval-order-async branch July 8, 2021 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inscrutable eval_order_dependence warning (futures related?)
4 participants