Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disallowed_type lint, this adds a field to the conf struct #7315

Merged
merged 1 commit into from
Jun 10, 2021

Conversation

DevinR528
Copy link
Contributor

@DevinR528 DevinR528 commented Jun 3, 2021

Fixes #7277

changelog: Add [`disallowed_type`] a lint that can enforce banning types specified in the config.

@rust-highfive
Copy link

r? @giraffate

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 3, 2021
@DevinR528 DevinR528 changed the title Disallowed ty Add disallowed_type lint, this adds a field to the conf struct Jun 3, 2021
@DevinR528
Copy link
Contributor Author

DevinR528 commented Jun 4, 2021

Looks like someone brought ICE to the party! CI failed because of 2 different ICE panics maybe just one?

clippy_lints/src/disallowed_type.rs Outdated Show resolved Hide resolved
@giraffate giraffate added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Jun 7, 2021
@DevinR528 DevinR528 force-pushed the disallowed-ty branch 2 times, most recently from 2b008d8 to e57441a Compare June 7, 2021 11:34
clippy_lints/src/disallowed_type.rs Outdated Show resolved Hide resolved
clippy_lints/src/disallowed_type.rs Outdated Show resolved Hide resolved
clippy_lints/src/disallowed_type.rs Show resolved Hide resolved
clippy_lints/src/disallowed_type.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@giraffate giraffate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, thanks! Can you squash commits?

Replace use of node_type -> node_type_opt, fix clippy warnings

Don't walk the hir unnecessarily let the visitor do it
@DevinR528
Copy link
Contributor Author

Squashed.

@giraffate
Copy link
Contributor

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented Jun 10, 2021

📌 Commit ea45e2a has been approved by giraffate

@bors
Copy link
Collaborator

bors commented Jun 10, 2021

⌛ Testing commit ea45e2a with merge c4636ab...

@bors
Copy link
Collaborator

bors commented Jun 10, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: giraffate
Pushing c4636ab to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New lint: disallowed_types based on config
4 participants