Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from-iter-instead-of-collect to pedantic #7375

Merged
merged 1 commit into from
Jun 19, 2021

Conversation

djc
Copy link
Contributor

@djc djc commented Jun 18, 2021

Since FromIterator will become part of the prelude, this lint being
warn by default is incongruous with the libs team position on the topic.

Fixes #7213.


changelog: moved [from_iter_instead_of_collect] to pedantic group

@rust-highfive
Copy link

r? @Manishearth

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 18, 2021
Since FromIterator will become part of the prelude, this lint being
warn by default is incongruous with the libs team position on the topic.
@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 19, 2021

📌 Commit a40fd6d has been approved by Manishearth

@bors
Copy link
Collaborator

bors commented Jun 19, 2021

⌛ Testing commit a40fd6d with merge 7869e62...

@bors
Copy link
Collaborator

bors commented Jun 19, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing 7869e62 to master...

@bors bors merged commit 7869e62 into rust-lang:master Jun 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

from_iter_instead_of_collect feels like a blanket ban of the FromIterator trait
4 participants