Fix wrong config option being suggested for deprecated wrong_pub_self_convention lint

[matthiaskrgr]

Problem:
for code like

#![warn(clippy::wrong_pub_self_convention)]
fn main() {
    println!("Hello, world!");
}

clippy will issue a warning to use a clippy.toml option instead:

warning: lint `clippy::wrong_pub_self_convention` has been removed: set the `avoid_breaking_exported_api` config option to `false` to enable the `wrong_self_convention` lint for public items
 --> src/main.rs:2:9
  |
2 | #![warn(clippy::wrong_pub_self_convention)]
  |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(renamed_and_removed_lints)]` on by default

But using the lint name as seen in the warning message
echo "avoid_breaking_exported_api = true\n" > clippy.toml

Will cause an error:

error: error reading Clippy's configuration file `/tmp/clippytest/clippy.toml`: unknown field `avoid_breaking_exported_api`, expected one of `avoid-breaking-exported-api`, ...

Replace the underscores with dashes in the deprecation message.

changelog: avoid_breaking_exported_api: suggest correct clippy config toml option in the deprecation message

[rust-highfive]

r? @giraffate

(rust-highfive has picked a reviewer for you, use r? to override)

[matthiaskrgr]

Hmm, apparently cargo dev update_lints will revert my fix 😆

[matthiaskrgr]

Seems that

    file_change |= replace_region_in_file(
        Path::new("clippy_lints/src/lib.rs"),
        "begin deprecated lints",
        "end deprecated lints",
        false,
        update_mode == UpdateMode::Change,
        || gen_deprecated(deprecated_lints.iter()),
    )
    .changed;

is causing this (update_lints.rs)

[matthiaskrgr]

I think i fixed it

[flip1995]

@bors r+

Thanks!

[bors]

📌 Commit 8276f26 has been approved by flip1995

[bors]

⌛ Testing commit 8276f26 with merge 404bd1a...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 404bd1a to master...