Fix emitting in nested (proc_)macros for nonstandard_macro_braces lint #7431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! @bors r+ |
|
📌 Commit 1d110f8 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
|
Hope this fixes it, good that it's still in |
|
Yeah, I was about to comment that we should keep an eye on it to see when and if it can leave the nursery. |
|
Sounds good to me! As soon as it's ready I'll enable it on a very macro (rules/fn like/derive/attribute) heavy project so that should exercise it pretty well, then maybe in a few weeks open a PR. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7422
changelog: fixes false positives in [
nonstandard_macro_braces]