mut_range_bound check for immediate break after mutation
#7607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @flip1995 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
dswij
commented
Aug 29, 2021
dswij
force-pushed
the
mut-range-bound-break
branch
2 times, most recently
from
b72baca
to
2035b1d
Compare
flip1995
reviewed
Aug 30, 2021
flip1995
added
S-waiting-on-author
|
☔ The latest upstream changes (presumably #7604) made this pull request unmergeable. Please resolve the merge conflicts. |
dswij
force-pushed
the
mut-range-bound-break
branch
from
2035b1d
to
47ecff6
Compare
flip1995
reviewed
Sep 6, 2021
dswij
force-pushed
the
mut-range-bound-break
branch
from
47ecff6
to
8300878
Compare
flip1995
reviewed
Sep 7, 2021
clippy_lints/src/loops/mod.rs
Outdated
Comment on lines
401
to
402
| /// False positive when mutation is not immediately followed by a break statement | ||
| /// False positive on nested expressions ([#6072](https://github.com/rust-lang/rust-clippy/issues/6072)) |
There was a problem hiding this comment.
Suggested change
| /// False positive when mutation is not immediately followed by a break statement | |
| /// False positive on nested expressions ([#6072](https://github.com/rust-lang/rust-clippy/issues/6072)) | |
| /// False positive when mutation is followed by a `break`, but the `break` is not immediately after the mutation: | |
| /// | |
| /// ``` | |
| /// x += 1; // x is range bound | |
| /// some_other_expr(); | |
| /// break; // leaves the loop so mutating is not an issue | |
| /// ``` | |
| /// | |
| /// False positive on nested loops ([#6072](https://github.com/rust-lang/rust-clippy/issues/6072)) |
dswij
force-pushed
the
mut-range-bound-break
branch
from
8300878
to
7c40cfd
Compare
dswij
force-pushed
the
mut-range-bound-break
branch
from
7c40cfd
to
dc6f7dc
Compare
|
@bors r+ Thanks! |
|
📌 Commit dc6f7dc has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7532
mut_range_boundignores mutation on range bounds that is placed immediately before break. Still warns if the break is not always reachable.changelog: [
mut_range_bound] ignore range bound mutations before immediate break