Fix suggestion for deref expressions in redundant_pattern_matching #7949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @flip1995 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
flip1995
reviewed
Nov 9, 2021
flip1995
reviewed
Nov 9, 2021
Serial-ATA
force-pushed
the
issue-7921
branch
from
7b94826
to
e54c341
Compare
flip1995
reviewed
Nov 9, 2021
| Applicability::MaybeIncorrect | ||
| } else { | ||
| Applicability::MachineApplicable | ||
| }; | ||
| let sugg = snippet_with_applicability(cx, op_span, "_", &mut app); | ||
|
|
||
| let sugg = Sugg::hir_with_macro_callsite(cx, result_expr, "_") |
There was a problem hiding this comment.
Why use with_macro_callsite here?
There was a problem hiding this comment.
Ah, just saw the test update. Nvm.
|
@bors r+ Thanks! |
|
📌 Commit e54c341 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: Fix suggestion for deref expressions in [
redundant_pattern_matching]closes: #7921