Non ascii in sigle literal #8034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @llogiq (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
llogiq
approved these changes
Nov 26, 2021
clippy_lints/src/unicode.rs
Outdated
| @@ -28,7 +28,7 @@ declare_clippy_lint! { | |||
|
|
|||
| declare_clippy_lint! { | |||
| /// ### What it does | |||
| /// Checks for non-ASCII characters in string literals. | |||
| /// Checks for non-ASCII characters in string literals or char. | |||
There was a problem hiding this comment.
Suggested change
| /// Checks for non-ASCII characters in string literals or char. | |
| /// Checks for non-ASCII characters in string and char literals. |
|
Thank you! @bors r+ |
|
📌 Commit cd8b724 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #8013
changelog:
non_ascii_literalwarn against non-ASCII withinchar, not juststrings