Check usages in ptr_arg
#8271
Merged
Check usages in ptr_arg
#8271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Track the argument when used to initialize simple `let` bindings * Check if the argument is passed to a function requiring the original type * Use `multipart_suggestion` rather than multiple suggestions * Check if the name given in the source code matches the name of the actual type
|
r? @flip1995 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
flip1995
reviewed
Jan 20, 2022
flip1995
added
S-waiting-on-author
|
@bors r+ Thanks! |
|
📌 Commit 048297b has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
hhirtz
added a commit
to LIHPC-Computational-Geometry/coupe
that referenced
this pull request
Apr 8, 2022
Update to Rust 1.60 extended clippy::ptr_arg somehow and now this triggers a false positive. See rust-lang/rust-clippy#8482 maybe relevant PR: rust-lang/rust-clippy#8271
hhirtz
added a commit
to LIHPC-Computational-Geometry/coupe
that referenced
this pull request
Apr 8, 2022
Update to Rust 1.60 extended clippy::ptr_arg somehow and now this triggers a false positive. See rust-lang/rust-clippy#8482 maybe relevant PR: rust-lang/rust-clippy#8271
superatomic
added a commit
to superatomic/xshe
that referenced
this pull request
Apr 28, 2022
Move shell script conversion to a separate file, `convert.rs`. They were previously in `main.rs`. Additionally, implement unsetting environment variables as described in #31. Note: until rust-lang/rust-clippy#8271 is added to Rust in 1.61, `#![allow(clippy::ptr_arg)]` has been added to the top of the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #214
fixes #1981
fixes #3381
fixes #6406
fixes #6964
This does not take into account the return type of the function currently, so
(&Vec<_>) -> &Vec<_>functions may still be false positives.The name given for the type also has to match the real type name, so
type Foo = Vec<u32>won't trigger the lint, buttype Vec = Vec<u32>will. I'm not sure if this is the best way to handle this, or if a note about the actual type should be added instead.changelog: Check if the argument is used in a way which requires the original type in
ptr_argchangelog: Lint mutable references in
ptr_arg