Suggest from_utf8_unchecked in const contexts #8612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @flip1995 (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #8610) made this pull request unmergeable. Please resolve the merge conflicts. |
SabrinaJewson
force-pushed
the
suggest-from-utf8-unchecked-in-const
branch
from
baa272b
to
7a80c23
Compare
|
|
|
Oh haha, I don't know how I didn't realize that 😅 . Thanks for pointing it out. |
flip1995
reviewed
Apr 6, 2022
Co-authored-by: Philipp Krones <hello@philkrones.com>
|
@bors r+ Thanks! |
|
📌 Commit 41ef4f7 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately I couldn't figure out how to check whether a given expression is in an
unsafecontext or not, so I just unconditionally emit the wrappingunsafe {}block in the suggestion. If there is an easy way to get it to work better then I would love to hear it.changelog: Suggest
from_utf8_uncheckedinstead offrom_utf8in const contexts for[`transmute_bytes_to_str`]refs: #8379