Don't lint manual_non_exhaustive when the enum variant is used
#8645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @xFrednet (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Jarcho
force-pushed
the
manual_non_exhaustive_5714
branch
from
5e84122
to
b0f8a31
Compare
xFrednet
approved these changes
Apr 11, 2022
|
This looks good to me, thank you for the implementation! I've marked one question, if this change was intentional, you can @bors d+ |
|
📌 Commit b0f8a31 has been approved by |
bors
added a commit
that referenced
this pull request
Apr 11, 2022
Don't lint `manual_non_exhaustive` when the enum variant is used fixes #5714 changelog: Don't lint `manual_non_exhaustive` when the enum variant is used
|
It seems like bors was a bit too quick and took my inline code mention as the real one 😅 @bors r- |
|
Looks like I messed up with some commands. Let's try this again: @bors delegate+ |
|
✌️ @Jarcho can now approve this pull request |
|
@bors r+ |
|
📌 Commit b0f8a31 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5714
changelog: Don't lint
manual_non_exhaustivewhen the enum variant is used