-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix empty_line_after_outer_attribute
false positive
#8892
Conversation
r? @Manishearth (rust-highfive has picked a reviewer for you, use r? to override) |
@bors r+ thanks! |
📌 Commit 9ee211a has been approved by |
…hearth Fix `empty_line_after_outer_attribute` false positive This PR fixes a false positive in `empty_line_after_outer_attribute`. Here is a minimal example that trigger the FP: ```rust #[derive(clap::Parser)] #[clap(after_help = "This ia a help message. You're welcome. ")] pub struct Args; ```
💔 Test failed - checks-action_test |
The changelog was missing. I hope my addition is a correct description of the fix 🙃 |
@bors retry |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Uh, this added |
I fixed this during the sync to rustc with commit rust-lang/rust@c22d4e6 |
Sorry, I wasn't aware of |
All good, you live and learn: In UI tests you can depend on files/crates in the |
This PR fixes a false positive in
empty_line_after_outer_attribute
.Here is a minimal example that trigger the FP:
changelog: PF: [
empty_line_after_outer_attribute
]: No longer lints empty lines in inner string values.