Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to iter_overeager_cloned #8960

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Jun 7, 2022

fixes: #8494

changelog: Don't lint iter_overeager_cloned on .cloned().flatten() when T::Item doesn't implement IntoIterator

* Don't lint on `.cloned().flatten()` when `T::Item` doesn't implement `IntoIterator`
* Reduce verbosity of lint message
* Narrow down the scope of the replacement range
@rust-highfive
Copy link

r? @giraffate

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 7, 2022
@giraffate
Copy link
Contributor

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented Jun 8, 2022

📌 Commit bf3ab59 has been approved by giraffate

@bors
Copy link
Collaborator

bors commented Jun 8, 2022

⌛ Testing commit bf3ab59 with merge ab8c8c6...

@bors
Copy link
Collaborator

bors commented Jun 8, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: giraffate
Pushing ab8c8c6 to master...

@bors bors merged commit ab8c8c6 into rust-lang:master Jun 8, 2022
@bors bors mentioned this pull request Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iter_overeager_cloned suggests code that doesn't compile
4 participants