enum_variant_names should ignore when all prefixes are _ #9032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @llogiq (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
llogiq
reviewed
Jun 25, 2022
llogiq
reviewed
Jun 25, 2022
|
Thank you for the PR. I only have a few suggestions / questions, otherwise this should be good to merge. |
Co-authored-by: llogiq <bogusandre@gmail.com>
|
Thank you! @bors r+ |
|
📌 Commit d827b83 has been approved by |
bors
added a commit
that referenced
this pull request
Jun 26, 2022
enum_variant_names should ignore when all prefixes are _ close #9018 When Enum prefix is only an underscore, we should not issue warnings. changelog: fix false positive in enum_variant_names
|
💔 Test failed - checks-action_remark_test |
|
It seems there is some markdown error. |
|
I created #9055 |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #9018
When Enum prefix is only an underscore, we should not issue warnings.
changelog: fix false positive in enum_variant_names