-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enum_variant_names should ignore when all prefixes are _ #9032
Conversation
r? @llogiq (rust-highfive has picked a reviewer for you, use r? to override) |
Thank you for the PR. I only have a few suggestions / questions, otherwise this should be good to merge. |
Co-authored-by: llogiq <bogusandre@gmail.com>
Thank you! @bors r+ |
📌 Commit d827b83 has been approved by |
enum_variant_names should ignore when all prefixes are _ close #9018 When Enum prefix is only an underscore, we should not issue warnings. changelog: fix false positive in enum_variant_names
💔 Test failed - checks-action_remark_test |
It seems there is some markdown error. |
I created #9055 |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
close #9018
When Enum prefix is only an underscore, we should not issue warnings.
changelog: fix false positive in enum_variant_names