Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve while_let_on_iterator suggestion inside an FnOnce closure #9134

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Improve while_let_on_iterator suggestion inside an FnOnce closure #9134

merged 1 commit into from
Jul 13, 2022

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Jul 7, 2022

changelog: Improve while_let_on_iterator suggestion inside an FnOnce closure

@rust-highfive
Copy link

r? @dswij

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 7, 2022
@bors
Copy link
Collaborator

bors commented Jul 7, 2022

☔ The latest upstream changes (presumably #9120) made this pull request unmergeable. Please resolve the merge conflicts.

dswij
dswij reviewed Jul 12, 2022
View reviewed changes
Copy link
Member

@dswij dswij left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I think overall it looks great. Just have one question on the test

tests/ui/while_let_on_iterator.rs Show resolved Hide resolved
@dswij
Copy link
Member

dswij commented Jul 13, 2022

Thanks for this! @bors r+

@bors
Copy link
Collaborator

bors commented Jul 13, 2022

📌 Commit 9fa12de has been approved by dswij

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jul 13, 2022

⌛ Testing commit 9fa12de with merge a7162f2...

@bors
Copy link
Collaborator

bors commented Jul 13, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: dswij
Pushing a7162f2 to master...

@bors bors merged commit a7162f2 into rust-lang:master Jul 13, 2022
@bors bors mentioned this pull request Jul 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dswij dswij dswij left review comments

Assignees

@dswij dswij

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jarcho @rust-highfive @bors @dswij