-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mismatching_type_param_order
false positive
#9146
Conversation
r? @llogiq (rust-highfive has picked a reviewer for you, use r? to override) |
r? @dswij sorry I took a while to get to this, would you mind taking a look? |
No worries! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking a look! The PR itself looks good to me, but I think we can add this info into the lint's docs in the "Limitation/Known Issue" section.
e.g. smth like this:
rust-clippy/clippy_lints/src/return_self_not_must_use.rs
Lines 24 to 26 in 4970527
/// ### Limitations | |
/// This lint is only applied on methods taking a `self` argument. It would be mostly noise | |
/// if it was added on constructors for example. |
Previously was giving false positive when an impl had a nontrivial generic argument such as a tuple. Don't lint on these cases.
Added limitations section |
Thanks for this! @bors r+ |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Thanks for the review @dswij ! |
changelog: Don't lint
mismatching_type_param_order
on complicated generic paramsfixes #8962