unwrap_used and expect_used: trigger on uses of their _err variants #9338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @llogiq (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
giraffate
reviewed
Aug 16, 2022
sgued
force-pushed
the
9331-unwrap-err-used
branch
from
ca0812d
to
c1e0435
Compare
giraffate
reviewed
Aug 17, 2022
There was a problem hiding this comment.
Can the tests be added to tests/ui/unwrap.rs,expect.rs? The tests/ui/unwrap_expect_used.rs file is a test when both unwrap_used and expect_used are enabled.
https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
If expect_used is enabled, instead:
|
@bors r+ Thanks! |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: [
unwrap_used]: lint uses ofunwrap_errchangelog: [
expect_used]: lint uses ofexpect_errfixes #9331