-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unwrap_used and expect_used: trigger on uses of their _err variants #9338
Conversation
r? @llogiq (rust-highfive has picked a reviewer for you, use r? to override) |
ca0812d
to
c1e0435
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the tests be added to tests/ui/unwrap.rs,expect.rs
? The tests/ui/unwrap_expect_used.rs
file is a test when both unwrap_used
and expect_used
are enabled.
https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
If expect_used is enabled, instead:
@bors r+ Thanks! |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
changelog: [
unwrap_used
]: lint uses ofunwrap_err
changelog: [
expect_used
]: lint uses ofexpect_err
fixes #9331