-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't lint on match pattern-binding in ´question_mark` #9348
Conversation
Fixes rust-lang#9347 Technically it is possible to have a blank match-pattern that does nothing, and we fail to lint. But its easier to be safe than sorry here.
r? @Alexendoo (rust-highfive has picked a reviewer for you, use r? to override) |
Great, thanks! @bors r+ |
Don't lint on match pattern-binding in ´question_mark` Fixes #9347 Technically it is possible to have a blank match-pattern that does nothing, and we fail to lint. But it's easier to be safe than sorry here.
And yeah no need to worry about weird things like |
💔 Test failed - checks-action_test |
@bors r+ |
💡 This pull request was already approved, no need to approve it again.
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Fixes #9347
Technically it is possible to have a blank match-pattern that does nothing, and we fail to lint. But it's easier to be safe than sorry here.
changelog: [
question_mark
]: don't lintif let
s with subpatterns