Use macro callsite when creating Sugg helper
#9410
Conversation
|
r? @xFrednet (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@rustbot author (Since this is still a draft PR :)) |
rustbot
added
S-waiting-on-author
| let get_whole_snippet = || { | ||
| if expr.span.from_expansion() { | ||
| snippet_with_macro_callsite(cx, expr.span, default) | ||
| let snippet_without_expansion = |cx, span: Span, default| { |
There was a problem hiding this comment.
I'm not sure if we want this in clippy utils
There was a problem hiding this comment.
For now, I would keep it local to this function. Macros are not the simplest thing to deal with, and I prefer contributors to ignore them rather than trying to add suggestions for them. But that is mostly my personal preference, you can extract it if you want 🙃
There was a problem hiding this comment.
That's fair. I'll leave it as it is then
dswij
changed the title
Sugg helperSugg helper
dswij
added
S-waiting-on-review
| let get_whole_snippet = || { | ||
| if expr.span.from_expansion() { | ||
| snippet_with_macro_callsite(cx, expr.span, default) | ||
| let snippet_without_expansion = |cx, span: Span, default| { |
There was a problem hiding this comment.
For now, I would keep it local to this function. Macros are not the simplest thing to deal with, and I prefer contributors to ignore them rather than trying to add suggestions for them. But that is mostly my personal preference, you can extract it if you want 🙃
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Closes #9375
changelog: Improvement: [
collapsible_if]: Suggestions now work with macros, by taking the call site into account.