-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tests in implicit_saturating_sub
lint
#9584
Conversation
r? @Jarcho (rust-highfive has picked a reviewer for you, use r? to override) |
r?@llogiq |
Just that one small nit about the variable name, then we can merge this. |
@llogiq your suggestions are implemented. Please take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for seeing this through.
@bors r+
You may have missed this, @bors r+ |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This adds more tests to the
implicit_saturating_sub
lint to rule out certain false positives that have appeared in the past.Now with those false positives out of the equation, we can move the lint to
style
.changelog: promote [
implicit-saturating-sub
] to thestyle
category