Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cast-nan-to-int lint #9617

Merged
merged 1 commit into from
Oct 12, 2022
Merged

add cast-nan-to-int lint #9617

merged 1 commit into from
Oct 12, 2022

Conversation

llogiq
Copy link
Contributor

@llogiq llogiq commented Oct 9, 2022

This fixes #371.

r? @Alexendoo


changelog: add [cast-nan-to-int] lint

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 9, 2022
@llogiq
Copy link
Contributor Author

llogiq commented Oct 10, 2022

I've added the note you suggested. Anything else needed?

@bors
Copy link
Collaborator

bors commented Oct 11, 2022

☔ The latest upstream changes (presumably #9572) made this pull request unmergeable. Please resolve the merge conflicts.

Copy link
Member

@Alexendoo Alexendoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing else, looks good!

you can r=me it with the conflict resolved

@llogiq
Copy link
Contributor Author

llogiq commented Oct 12, 2022

Thank you for the review!

@bors r=@Alexendoo

@bors
Copy link
Collaborator

bors commented Oct 12, 2022

📌 Commit e4c80f2 has been approved by Alexendoo

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Oct 12, 2022

⌛ Testing commit e4c80f2 with merge b8a9a50...

@bors
Copy link
Collaborator

bors commented Oct 12, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing b8a9a50 to master...

@bors bors merged commit b8a9a50 into rust-lang:master Oct 12, 2022
@llogiq llogiq deleted the cast-nan-to-int branch October 12, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Casting a known NaN value to an integral type
4 participants