Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allow-print-in-tests config #9797

Merged
merged 1 commit into from
Nov 5, 2022
Merged

Conversation

trevarj
Copy link
Contributor

@trevarj trevarj commented Nov 4, 2022

Add a config, allow-print-in-tests, that can be set in clippy.toml which allows the usage of [e]print[ln]! macros in tests.

Closes #9795


changelog: Enhancement: [print_stdout], [print_stderr]: Can now be enabled in test with the allow-print-in-tests config value

Add a config, allow-print-in-tests, that can be set in clippy.toml which
allows the usage of `[e]print[ln]!` macros in tests.

Closes rust-lang#9795
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @flip1995 (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 4, 2022
@xFrednet
Copy link
Member

xFrednet commented Nov 5, 2022

r? @xFrednet

@rust-highfive rust-highfive assigned xFrednet and unassigned flip1995 Nov 5, 2022
@xFrednet
Copy link
Member

xFrednet commented Nov 5, 2022

Hey @trevarj, welcome to Clippy 👋. The implementation and tests both look good to me, thank you for the help. I hope you had fun during the implementation :)

@bors r+

@bors

This comment was marked as off-topic.

@bors

This comment was marked as off-topic.

bors added a commit that referenced this pull request Nov 5, 2022
Add allow-print-in-tests config

Add a config, allow-print-in-tests, that can be set in clippy.toml which allows the usage of `[e]print[ln]!` macros in tests.

Closes #9795

---

changelog: add config to allow prints in tests
@xFrednet

This comment was marked as off-topic.

@xFrednet
Copy link
Member

xFrednet commented Nov 5, 2022

Sorry, my r+ was a bit too fast. I updated the changelog entry. Now we can merge it 🙃

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 5, 2022

📌 Commit ddcfff6 has been approved by xFrednet

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Nov 5, 2022

⌛ Testing commit ddcfff6 with merge e547411...

@bors
Copy link
Collaborator

bors commented Nov 5, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing e547411 to master...

@bors bors merged commit e547411 into rust-lang:master Nov 5, 2022
@trevarj trevarj deleted the print-config branch November 6, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config for allowing print/println macros in tests
5 participants