Fix aligning of method chains (more-or-less), add various unit tests, and add matching angle brackets. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regular expressions are probably kind of wrong for things like
self.foo.something::<X>()
.more();
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
…typed. Also add an interactive command for finding the matching `<`. I'd like to bind this to `C-c >` (reserved for major modes), but I can't figure out what the local keymap is for rust-mode (help!).
nikomatsakis
changed the title
|
Sweet! (The angle-bracket matching is not quite smart enough to e.g. skip over the content of comments or string literals. But I do not see that as a reason to reject it.) |
pnkfelix
added a commit
that referenced
this pull request
Feb 6, 2015
Fix aligning of method chains (more-or-less), add various unit tests, and add matching angle brackets.
|
@pnkfelix yes, good point, it also doesn't detect mismatched kinds of parens, which would be useful. But the presence of comments or string literals within types seems pretty unlikely in any case. |
|
(in any case a mismatch is fairly harmless) |
pnkfelix
added a commit
to pnkfelix/rust-mode
that referenced
this pull request
Feb 6, 2015
… `>` is typed." This reverts commit 55e7483. Undoing PR rust-lang#22 since it broke emacs23 support.
This was referenced Feb 6, 2015
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<to be briefly highlighted when>is typed (configurable to "off", defaults to "on").Caveat for method chains: The regular expressions are probably kind of wrong for things like
Fixes #13.
Fixes #23.