-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Privacy assertion failure with staged_api
and duplicated module name
#104249
Labels
C-bug
Category: This is a bug.
I-ICE
Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️
requires-nightly
This issue requires a nightly compiler in some way.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Comments
|
Fixed in #104546. |
petrochenkov
added a commit
to petrochenkov/rust
that referenced
this issue
Nov 23, 2022
Optimizations removed in the previous commit required this function to behave incorrectly, but now those optimizations are gone so we can fix the bug. Fixes rust-lang#104249
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
Nov 25, 2022
privacy: Fix more (potential) issues with effective visibilities Continuation of rust-lang#103965. See individual commits for more detailed description of the changes. The shortcuts removed in rust-lang@4eb63f6 and rust-lang@c7c7d16 could actually be correct (or correct after some tweaks), but they used global reasoning like "we can skip this update because if the code compiles then some other update should do the same thing eventually". I have some expertise in this area, but I still have doubt whether such global reasoning was correct or not, especially in presence of all possible exotic cases with imports. After this PR all table changes should be "locally correct" after every update, even if it may be overcautious. If similar optimizations are introduced again they will need detailed comments explaining why it's legal to do what they do and providing proofs. Fixes rust-lang#104249. Fixes rust-lang#104539.
RalfJung
pushed a commit
to RalfJung/rust-analyzer
that referenced
this issue
Apr 20, 2024
privacy: Fix more (potential) issues with effective visibilities Continuation of rust-lang/rust#103965. See individual commits for more detailed description of the changes. The shortcuts removed in rust-lang/rust@4eb63f6 and rust-lang/rust@c7c7d16 could actually be correct (or correct after some tweaks), but they used global reasoning like "we can skip this update because if the code compiles then some other update should do the same thing eventually". I have some expertise in this area, but I still have doubt whether such global reasoning was correct or not, especially in presence of all possible exotic cases with imports. After this PR all table changes should be "locally correct" after every update, even if it may be overcautious. If similar optimizations are introduced again they will need detailed comments explaining why it's legal to do what they do and providing proofs. Fixes rust-lang/rust#104249. Fixes rust-lang/rust#104539.
RalfJung
pushed a commit
to RalfJung/rust-analyzer
that referenced
this issue
Apr 27, 2024
privacy: Fix more (potential) issues with effective visibilities Continuation of rust-lang/rust#103965. See individual commits for more detailed description of the changes. The shortcuts removed in rust-lang/rust@4eb63f6 and rust-lang/rust@c7c7d16 could actually be correct (or correct after some tweaks), but they used global reasoning like "we can skip this update because if the code compiles then some other update should do the same thing eventually". I have some expertise in this area, but I still have doubt whether such global reasoning was correct or not, especially in presence of all possible exotic cases with imports. After this PR all table changes should be "locally correct" after every update, even if it may be overcautious. If similar optimizations are introduced again they will need detailed comments explaining why it's legal to do what they do and providing proofs. Fixes rust-lang/rust#104249. Fixes rust-lang/rust#104539.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-bug
Category: This is a bug.
I-ICE
Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️
requires-nightly
This issue requires a nightly compiler in some way.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Found with a modified fuzz-rustc.
Code
Alternative input with stability attributes
Error output with debug assertions
Full output including backtrace
Regression
This is a new assertion, added in 448261a of #103965 (@petrochenkov). I don't know whether this indicates a pre-existing bug.
Version
Built stage1 on
x86_64-apple-darwin
at revision 01a6f30 withdebug-assertions = true
The text was updated successfully, but these errors were encountered: