privacy: Relax some asserts on effective visibilities #104546
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first invariant is hard to enforce in presence of errors. The second invariant is expensive to enforce fully precisely, so it no longer makes sense given that we were trying to enforce it for performance
|
r? @lcnr (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
This was referenced Nov 17, 2022
|
looks sensible. still want someone who knows about this code look at this as there might be a good way to keep these asserts if they're useful r? compiler |
|
Looks reasonable to me, but I don't think I count as someone who knows this code so I'll reroll too. r? compiler |
eholk
approved these changes
Nov 21, 2022
| @@ -167,7 +166,7 @@ impl EffectiveVisibilities { | |||
| // and all effective visibilities are larger or equal than private visibility. | |||
| let private_vis = Visibility::Restricted(tcx.parent_module_from_def_id(def_id)); | |||
| let span = tcx.def_span(def_id.to_def_id()); | |||
| if !ev.direct.is_at_least(private_vis, tcx) { | |||
| if !ev.direct.is_at_least(private_vis, tcx) && tcx.sess.has_errors().is_none() { | |||
There was a problem hiding this comment.
Is it possible to delay span bug here and the assert you removed below?
compiler-errors
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first invariant is hard to enforce in presence of errors.
The second invariant is expensive to enforce fully precisely, so it no longer makes sense given that we were trying to enforce it for performance.
Fixes #104249.
Fixes #104539.
(Both ICEs happen only if the compiler is built with debug assertions.)