Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JsonDocLint: Check local ID's in paths are also in index. #106433

Closed
aDotInTheVoid opened this issue Jan 4, 2023 · 0 comments · Fixed by #106546
Closed

JsonDocLint: Check local ID's in paths are also in index. #106433

aDotInTheVoid opened this issue Jan 4, 2023 · 0 comments · Fixed by #106546
Labels
A-rustdoc-json Area: Rustdoc JSON backend T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@aDotInTheVoid
Copy link
Member

Would have caught #104064

  1. This isn't caught by jsondoclint, although it probably should be. (We can easily add a check that all item's in paths with crate_id 0 (local) are also in in the index.

Originally posted by @aDotInTheVoid in #104064 (comment)
@aDotInTheVoid aDotInTheVoid added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-json Area: Rustdoc JSON backend labels Jan 4, 2023
@aDotInTheVoid aDotInTheVoid mentioned this issue Jan 6, 2023
Merged
JohnTitor pushed a commit to JohnTitor/rust that referenced this issue Jan 8, 2023
Rollup merge of rust-lang#106546 - aDotInTheVoid:jsondoclint-path-loc…
4f138f1 
…al-item, r=notriddle

jsondoclint: Check local items in `paths` are also in `index`.

Would have caught rust-lang#104064 (if core.json was linted in CI).

Closes rust-lang#106433.

r? rustdoc
@bors bors closed this as completed in 7997ff6 Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rustdoc-json Area: Rustdoc JSON backend T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

jsondoclint: Check local items in paths are also in index. aDotInTheVoid/rust
1 participant
@aDotInTheVoid