Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: trait from other crate is not linked #120993

Closed
mstange opened this issue Feb 12, 2024 · 4 comments · Fixed by rust-lang/cargo#13481
Closed

rustdoc: trait from other crate is not linked #120993

mstange opened this issue Feb 12, 2024 · 4 comments · Fixed by rust-lang/cargo#13481
Assignees
Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@mstange
Copy link

mstange commented Feb 12, 2024

On https://docs.rs/http-body-util/0.1.0/http_body_util/struct.StreamBody.html I was trying to find out what a Stream is.

Under "Trait Implementations", I see the following:

impl<S, D, E> Body for StreamBody<S> where
    S: Stream<Item = Result<Frame<D>, E>>,
    D: Buf,

Here it would be nice if I could click the "Stream" part in S: Stream and get to https://docs.rs/futures-util/0.3.14/futures_util/stream/trait.Stream.html .

@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Feb 12, 2024
@fmease fmease added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. C-bug Category: This is a bug. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Feb 13, 2024
@fmease
Copy link
Member

fmease commented Feb 13, 2024

Huh, this might be a regression and if so very likely the same regression as #120983.

@GuillaumeGomez
Copy link
Member

Taking a look.

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Feb 22, 2024

So the problem isn't actually rustdoc here but cargo: when there are no other deps locally present, rustdoc expects a map of URLs to know where to link for foreign items. However, in this case, this is a reexport of a foreign reexport, meaning we need to have access to a grand-child location, which we currently don't have. I'm checking with the cargo team to fix this issue.

@GuillaumeGomez
Copy link
Member

I opened rust-lang/cargo#13481, it should fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants