-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression: unsafe precondition(s) violated: slice::get_unchecked_mut requires that the index is within the slice #123285
Comments
Most likely we will just close this as won't fix, but this has a lot of breakage -- probably ~300-400 crates in total across the Crater run (tests or build scripts). At minimum it'll be in release notes and possibly blog post as "hey, we're doing new checking"... |
This is about what I expected 🤷 One of the biggest offenders is that we didn't have any documentation for the preconditions of The PR that originally added these checks already has the relnotes label, it's #120594. The implementation has evolved a bit since that PR, but the observable behavior for most users is the same as in that PR. |
We discussed this in the libs meeting and agree that there's probably nothing to be done on our end. Most of these seem to be from very outdated dependencies, so a fix in most cases would be to simply update dependencies. |
If you need something else to link, #117039 was the libs-api FCP that Those doc clarifications landed in 1.75, then (as was mentioned above) it's #116915 in 1.76 that actually started directly exploiting this UB, so the fact that we're actually detecting violations now seems like pure win. |
Seems to have been resolved as "tell people as clearly as possible to experience bij". Closing! |
reverse-deps of libsodium-sys 0.2.5, pnet_packet 0.26:
"unsafe precondition(s) violated: slice::from_raw_parts requires the pointer to be aligned and non-null, and the total size of the slice not to exceed
isize::MAX
"The text was updated successfully, but these errors were encountered: