-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking issue for release notes of #124032: Replace sort implementations #129661
Comments
cc @Voultapher @orlp if you want to have input on the relnotes here. |
Sketch for the compatibility aspect (not covering the details of the performance improvement): The implementations of sort functions ( |
|
Regarding how to communicate the performance improvements, saying ~2x for both stable and unstable sort is somewhat based in reality, however I'd much prefer not to mention a single number x or % improvement, as that depends on the input pattern, input length and input type, and we see in our testing changes ranging from no change at all, all the way up to 17x faster execution. I'd rather we say that the performance improved significantly and link to the relevant section in the design documents that explains our methodology and results for evaluating the change in performance |
Should probably use these permalinks specifically: |
Do we have any source of randomness in the unstable sort to ensure it's really unstable (like hashmaps)? If not the compat note could also mention that the order changed in case someone accidentally relied on it. |
No, we do not, it's deterministic within a version. |
...and yes, it was in fact the case that someone asserted on this order in a test and the test was regressed as a result. |
We do right now. I don't know if we actually guarantee this, and perhaps we could in the future use randomness for e.g. pivot selection. It's a bit weird because the current stable "current implementation" notes mention determinism, but.. well, it's in the "current implementation" section, not general guarantees. |
It can be useful to have the ability to fix typos. I plan on keeping these links stable. |
This has been included in the release notes and libs is satisfied with the wording, closing. |
This issue tracks the release notes text for #124032.
Release notes text:
The section title will be de-duplicated by the release team with other release notes issues.
Prefer to use the standard titles from previous releases.
More than one section can be included if needed.
Release blog section (if any, leave blank if no section is expected):
The text was updated successfully, but these errors were encountered: