core::str::Str.as_slice() should be renamed as_str() #14433

lilyball · 2014-05-26T02:13:21Z

The method as_slice() in the core::str::Str trait should be renamed to as_str(). This avoids the name collision with core::slice::Vector.as_slice() for types that need to implement both Vector and Str (as I believe Vec<Ascii> should).

I'm filing this issue now to give a chance for anyone to suggest any reasons why this is a bad idea. Otherwise I will go ahead and make the change myself.

The text was updated successfully, but these errors were encountered:

richo · 2014-05-26T04:49:42Z

I'm working in this general direction with my string refactoring
On 25/05/2014 7:13 pm, "Kevin Ballard" notifications@github.com wrote:

The method as_slice() in the core::str::Str trait should be renamed to
as_str(). This avoids the name collision with
core::slice::Vector.as_slice() for types that need to implement both
Vector and Str (as I believe Vec should).

I'm filing this issue now to give a chance for anyone to suggest any
reasons why this is a bad idea. Otherwise I will go ahead and make the
change myself.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/14433
.

AdamCanady · 2014-08-20T03:21:34Z

I can make this change since it looks like it still needs to be complete?

huonw · 2014-09-07T09:50:39Z

cc @aturon

Manishearth · 2014-09-07T13:11:14Z

I don't mind working on this if it needs to be done.

aturon · 2014-09-08T03:35:37Z

@Manishearth this will likely be done as part of the API stabilization for strings, which should be wrapping up this week.

richo · 2014-09-10T09:37:06Z

I started on this but it's more work than I expected. I'll do something automated if noone beats me to it.

This closes rust-lang#14433 [breaking-change]

japaric · 2014-11-04T20:18:27Z

@aturon Should this still be done for consistency?

There are still a bunch of as_slice (a lot of them in assert_eq!s) in the rust repo, but those are likely to disappear now that we can use &*string/string[], and in the future string == "foo". So, if we want to do this, I think it makes sense to do it after we remove all those as_slices, to reduce the amount of work.

aturon · 2014-11-04T20:20:08Z

@japaric Yes and yes. This has been waiting a bit while the ergonomics for as_slice were improved.

(Also, in general we haven't done API stabilization for str yet.)

richo · 2014-11-04T20:34:05Z

I still have the machinery to do this kicking around somewhere from last time.

iirc, my last PR got closed with something like "not yet", say the word and I'll reopen.

aturon · 2014-11-04T20:41:53Z

@richo Awesome, and thanks for your patience!

richo · 2014-11-04T20:43:28Z

No stress. (Thanks for dealing with my often stream of consciousness issues and PRs!).

Should I take it that this is worth doing now or wait for the next meeting?

aturon · 2014-11-04T20:45:43Z

@richo Let me discuss the staging with the team and get back to you.

steveklabnik · 2015-02-15T18:41:30Z

Traige: this is still true today

richo · 2015-02-15T18:46:57Z

Offer to do it stands

aturon · 2015-02-16T19:23:10Z

Nominating for 1.0-beta P-backcompat-libs.

pnkfelix · 2015-02-19T21:22:11Z

1.0 beta, P-backcompat-libs, I-needs-decision.

nikomatsakis · 2015-03-04T19:50:23Z

Annoyingly, I can't assign this to @richo, but it seems he's got it under control (thanks!). So let this serve as an "assignment" :)

This commit: * Introduces `std::convert`, providing an implementation of RFC 529. * Deprecates the `AsPath`, `AsOsStr`, and `IntoBytes` traits, all in favor of the corresponding generic conversion traits. Consequently, various IO APIs now take `AsRef<Path>` rather than `AsPath`, and so on. Since the types provided by `std` implement both traits, this should cause relatively little breakage. * Deprecates many `from_foo` constructors in favor of `from`. * Changes `PathBuf::new` to take no argument (creating an empty buffer, as per convention). The previous behavior is now available as `PathBuf::from`. * De-stabilizes `IntoCow`. It's not clear whether we need this separate trait. Closes rust-lang#22751 Closes rust-lang#14433 [breaking-change]

richo · 2015-03-24T21:15:26Z

\o/

…, r=Veykril Add doc-alias based completion Closes rust-lang#14406. I adapted the parsing code from the CfgExpr parsing code, maybe there's a better abstraction for both, or attribute parsing in general. It also includes `doc(hidden)`-parsing, which means it could replace the other function. There are a few tests for parsing. `process_all_names` changed the most, I added some docs there to explain what happens. Many call sites just pass an empy vec to `add_path_resolution`'s `doc_aliases`, since either it doesn't make sense to pass anything (e.g. visibility completion) or I don't know where to get them from. Shouldn't really matter, as it will just not show aliases if the vec is empty and we can extend alias completion in these cases later. I added two tests in `special.rs` for struct name completion (which was the main thing I wanted). I also tried function and field names, but these don't work yet. I want to add those in a follow-up PR.

…2, r=Veykril doc(alias)-based completion round 2 Follow-up on rust-lang#14433 We can now complete fields, functions and some use/mods. Flyimports don't behave, I don't really have the time to understand the structure there either. While reading the flyimport code, I removed one method only used there, the closure-tree was a bit confusing, I can revert that if you want.

huonw added the A-libs label Sep 7, 2014

richo added a commit to richo/rust that referenced this issue Sep 11, 2014

rename String::as_slice() to String::as_str()

73b7912

This closes rust-lang#14433 [breaking-change]

richo mentioned this issue Sep 11, 2014

Rename to as str #17171

Closed

aturon added the I-nominated label Feb 16, 2015

pnkfelix added the P-backcompat-libs label Feb 19, 2015

pnkfelix added this to the 1.0 beta milestone Feb 19, 2015

pnkfelix added I-needs-decision Issue: In need of a decision. and removed I-nominated labels Feb 19, 2015

richo mentioned this issue Feb 20, 2015

Remove unnecessary calls to Str::as_slice #22561

Merged

aturon mentioned this issue Mar 24, 2015

Add generic conversion traits #23538

Closed

alexcrichton assigned aturon Mar 24, 2015

aturon closed this as completed in 8389253 Mar 24, 2015

axil mentioned this issue Aug 21, 2019

as_slice -> as_str in the docs #63792

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

core::str::Str.as_slice() should be renamed as_str() #14433

core::str::Str.as_slice() should be renamed as_str() #14433

lilyball commented May 26, 2014

richo commented May 26, 2014

AdamCanady commented Aug 20, 2014

huonw commented Sep 7, 2014

Manishearth commented Sep 7, 2014

aturon commented Sep 8, 2014

richo commented Sep 10, 2014

japaric commented Nov 4, 2014

aturon commented Nov 4, 2014

richo commented Nov 4, 2014

aturon commented Nov 4, 2014

richo commented Nov 4, 2014

aturon commented Nov 4, 2014

steveklabnik commented Feb 15, 2015

richo commented Feb 15, 2015

aturon commented Feb 16, 2015

pnkfelix commented Feb 19, 2015

nikomatsakis commented Mar 4, 2015

richo commented Mar 24, 2015

core::str::Str.as_slice() should be renamed as_str() #14433

core::str::Str.as_slice() should be renamed as_str() #14433

Comments

lilyball commented May 26, 2014

richo commented May 26, 2014

AdamCanady commented Aug 20, 2014

huonw commented Sep 7, 2014

Manishearth commented Sep 7, 2014

aturon commented Sep 8, 2014

richo commented Sep 10, 2014

japaric commented Nov 4, 2014

aturon commented Nov 4, 2014

richo commented Nov 4, 2014

aturon commented Nov 4, 2014

richo commented Nov 4, 2014

aturon commented Nov 4, 2014

steveklabnik commented Feb 15, 2015

richo commented Feb 15, 2015

aturon commented Feb 16, 2015

pnkfelix commented Feb 19, 2015

nikomatsakis commented Mar 4, 2015

richo commented Mar 24, 2015