Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize str::unsafe::slice_bytes #1995

Closed
brson opened this issue Mar 15, 2012 · 0 comments
Closed

Optimize str::unsafe::slice_bytes #1995

brson opened this issue Mar 15, 2012 · 0 comments
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. I-slow Issue: Problems and improvements with respect to performance of generated code.

Comments

@brson
Copy link
Contributor

brson commented Mar 15, 2012

This function is used all over the str module. It should be compile to a malloc + memcpy, but currently it uses vec::slice, which is copies elements one at a time calling take glue on each.
@brson brson closed this as completed in bcf44f8 Mar 16, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. I-slow Issue: Problems and improvements with respect to performance of generated code.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brson