-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking issue for SipHash13/SipHash24 #34767
Comments
The referenced tracking issue was closed and was actually about changing the algorithm. cc rust-lang#34767
std: Correct tracking issue for SipHash{13,24} The referenced tracking issue was closed and was actually about changing the algorithm. cc rust-lang#34767
The libs team discussed these types, and are placing them into final comment period to deprecate While That being said, we are interested in moving forward on standard library support for faster hash maps and sets for small keys like integers where HashDoS is not a concern. This would most likely involve the addition of a |
The libs team discussed this during triage yesterday and the conclusion was to deprecate |
This commit is intended to be backported to the 1.13 branch, and works with the following APIs: Stabilized * `i32::checked_abs` * `i32::wrapping_abs` * `i32::overflowing_abs` * `RefCell::try_borrow` * `RefCell::try_borrow_mut` * `DefaultHasher` * `DefaultHasher::new` * `DefaultHasher::default` Deprecated * `BinaryHeap::push_pop` * `BinaryHeap::replace` * `SipHash13` * `SipHash24` * `SipHasher` - use `DefaultHasher` instead in the `std::collections::hash_map` module Closes rust-lang#28147 Closes rust-lang#34767 Closes rust-lang#35057 Closes rust-lang#35070
std: Stabilize and deprecate APIs for 1.13 This commit is intended to be backported to the 1.13 branch, and works with the following APIs: Stabilized * `i32::checked_abs` * `i32::wrapping_abs` * `i32::overflowing_abs` * `RefCell::try_borrow` * `RefCell::try_borrow_mut` Deprecated * `BinaryHeap::push_pop` * `BinaryHeap::replace` * `SipHash13` * `SipHash24` * `SipHasher` - use `DefaultHasher` instead in the `std::collections::hash_map` module Closes #28147 Closes #34767 Closes #35057 Closes #35070
The I’d like libcore to provide non-deprecated API for this functionality: #37071 |
This commit is intended to be backported to the 1.13 branch, and works with the following APIs: Stabilized * `i32::checked_abs` * `i32::wrapping_abs` * `i32::overflowing_abs` * `RefCell::try_borrow` * `RefCell::try_borrow_mut` * `DefaultHasher` * `DefaultHasher::new` * `DefaultHasher::default` Deprecated * `BinaryHeap::push_pop` * `BinaryHeap::replace` * `SipHash13` * `SipHash24` * `SipHasher` - use `DefaultHasher` instead in the `std::collections::hash_map` module Closes rust-lang#28147 Closes rust-lang#34767 Closes rust-lang#35057 Closes rust-lang#35070
@sfackler, is the concern here that the library team doesn't want to keep around hashers that aren't currently used in |
When the |
#49108 "removed" |
Added in #33940, these two structs which implement
Hasher
live in thestd::hash
module. This issue will track their stabilization, and some open questions when we added them were:SipHasher
is stable, but perhaps we don't want to expand?SipHasher
name?The text was updated successfully, but these errors were encountered: