Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for SipHash13/SipHash24 #34767

Closed
alexcrichton opened this Issue Jul 11, 2016 · 6 comments

Comments

Assignees
No one assigned
Labels
B-unstable T-libs final-comment-period
Projects
None yet
Milestone
No milestone
5 participants
@alexcrichton @sfackler @SimonSapin @jimblandy @eisterman
@alexcrichton
Copy link
Member

alexcrichton commented Jul 11, 2016

Added in #33940, these two structs which implement Hasher live in the std::hash module. This issue will track their stabilization, and some open questions when we added them were:

  • Do we want to export any more hasher implementations? Right now SipHasher is stable, but perhaps we don't want to expand?
  • If we do stabilize, what to do about the SipHasher name?

@alexcrichton alexcrichton added T-libs B-unstable labels Jul 11, 2016

alexcrichton added a commit to alexcrichton/rust that referenced this issue Jul 11, 2016

@alexcrichton
std: Correct tracking issue for SipHash{13,24} 
The referenced tracking issue was closed and was actually about changing the
algorithm.

cc rust-lang#34767
767e149

@alexcrichton alexcrichton referenced this issue Jul 11, 2016

Merged

std: Correct tracking issue for SipHash{13,24} #34768

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Jul 16, 2016

@GuillaumeGomez
Rollup merge of rust-lang#34768 - alexcrichton:issue-audit, r=aturon 
std: Correct tracking issue for SipHash{13,24}

The referenced tracking issue was closed and was actually about changing the
algorithm.

cc rust-lang#34767
ad7a697

@alexcrichton alexcrichton added the I-nominated label Aug 29, 2016

@sfackler sfackler added final-comment-period and removed I-nominated labels Sep 7, 2016

@sfackler

This comment has been minimized.

Sign in to view
Copy link
Member

sfackler commented Sep 7, 2016

The libs team discussed these types, and are placing them into final comment period to deprecate SipHasher, SipHash13, and SipHash24, and then remove SipHash13 and SipHash24 in a future release.

While RandomState is currently implemented with SipHash-1-3, this will not necessarily continue to be the case in the future if, for example, a faster cryptographic hash is developed or security flaws are found in it. We don't want to be forced to keep these implementations around forever if that happens.

That being said, we are interested in moving forward on standard library support for faster hash maps and sets for small keys like integers where HashDoS is not a concern. This would most likely involve the addition of a FastHasher backed by something like FNV, and possibly FashHashMap and FastHashSet type definitions.
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Sep 29, 2016

The libs team discussed this during triage yesterday and the conclusion was to deprecate

alexcrichton added a commit to alexcrichton/rust that referenced this issue Sep 29, 2016

@alexcrichton
std: Stabilize and deprecate APIs for 1.13 
This commit is intended to be backported to the 1.13 branch, and works with the
following APIs:

Stabilized

* `i32::checked_abs`
* `i32::wrapping_abs`
* `i32::overflowing_abs`
* `RefCell::try_borrow`
* `RefCell::try_borrow_mut`

Deprecated

* `BinaryHeap::push_pop`
* `BinaryHeap::replace`
* `SipHash13`
* `SipHash24`
* `SipHasher` - use `DefaultHasher` instead in the `std::collections::hash_map`
  module

Closes rust-lang#28147
Closes rust-lang#34767
Closes rust-lang#35057
Closes rust-lang#35070
cbbc94a

@alexcrichton alexcrichton referenced this issue Sep 29, 2016

Merged

std: Stabilize and deprecate APIs for 1.13 #36815

alexcrichton added a commit to alexcrichton/rust that referenced this issue Sep 29, 2016

@alexcrichton
std: Stabilize and deprecate APIs for 1.13 
This commit is intended to be backported to the 1.13 branch, and works with the
following APIs:

Stabilized

* `i32::checked_abs`
* `i32::wrapping_abs`
* `i32::overflowing_abs`
* `RefCell::try_borrow`
* `RefCell::try_borrow_mut`

Deprecated

* `BinaryHeap::push_pop`
* `BinaryHeap::replace`
* `SipHash13`
* `SipHash24`
* `SipHasher` - use `DefaultHasher` instead in the `std::collections::hash_map`
  module

Closes rust-lang#28147
Closes rust-lang#34767
Closes rust-lang#35057
Closes rust-lang#35070
672996f

alexcrichton added a commit to alexcrichton/rust that referenced this issue Sep 29, 2016

@alexcrichton
std: Stabilize and deprecate APIs for 1.13 
This commit is intended to be backported to the 1.13 branch, and works with the
following APIs:

Stabilized

* `i32::checked_abs`
* `i32::wrapping_abs`
* `i32::overflowing_abs`
* `RefCell::try_borrow`
* `RefCell::try_borrow_mut`

Deprecated

* `BinaryHeap::push_pop`
* `BinaryHeap::replace`
* `SipHash13`
* `SipHash24`
* `SipHasher` - use `DefaultHasher` instead in the `std::collections::hash_map`
  module

Closes rust-lang#28147
Closes rust-lang#34767
Closes rust-lang#35057
Closes rust-lang#35070
11c41f0

alexcrichton added a commit to alexcrichton/rust that referenced this issue Sep 29, 2016

@alexcrichton
std: Stabilize and deprecate APIs for 1.13 
This commit is intended to be backported to the 1.13 branch, and works with the
following APIs:

Stabilized

* `i32::checked_abs`
* `i32::wrapping_abs`
* `i32::overflowing_abs`
* `RefCell::try_borrow`
* `RefCell::try_borrow_mut`
* `DefaultHasher`
* `DefaultHasher::new`
* `DefaultHasher::default`

Deprecated

* `BinaryHeap::push_pop`
* `BinaryHeap::replace`
* `SipHash13`
* `SipHash24`
* `SipHasher` - use `DefaultHasher` instead in the `std::collections::hash_map`
  module

Closes rust-lang#28147
Closes rust-lang#34767
Closes rust-lang#35057
Closes rust-lang#35070
7efde9c

alexcrichton added a commit to alexcrichton/rust that referenced this issue Sep 29, 2016

@alexcrichton
std: Stabilize and deprecate APIs for 1.13 
This commit is intended to be backported to the 1.13 branch, and works with the
following APIs:

Stabilized

* `i32::checked_abs`
* `i32::wrapping_abs`
* `i32::overflowing_abs`
* `RefCell::try_borrow`
* `RefCell::try_borrow_mut`
* `DefaultHasher`
* `DefaultHasher::new`
* `DefaultHasher::default`

Deprecated

* `BinaryHeap::push_pop`
* `BinaryHeap::replace`
* `SipHash13`
* `SipHash24`
* `SipHasher` - use `DefaultHasher` instead in the `std::collections::hash_map`
  module

Closes rust-lang#28147
Closes rust-lang#34767
Closes rust-lang#35057
Closes rust-lang#35070
ba3cf9c

alexcrichton added a commit to alexcrichton/rust that referenced this issue Sep 29, 2016

@alexcrichton
std: Stabilize and deprecate APIs for 1.13 
This commit is intended to be backported to the 1.13 branch, and works with the
following APIs:

Stabilized

* `i32::checked_abs`
* `i32::wrapping_abs`
* `i32::overflowing_abs`
* `RefCell::try_borrow`
* `RefCell::try_borrow_mut`
* `DefaultHasher`
* `DefaultHasher::new`
* `DefaultHasher::default`

Deprecated

* `BinaryHeap::push_pop`
* `BinaryHeap::replace`
* `SipHash13`
* `SipHash24`
* `SipHasher` - use `DefaultHasher` instead in the `std::collections::hash_map`
  module

Closes rust-lang#28147
Closes rust-lang#34767
Closes rust-lang#35057
Closes rust-lang#35070
1b3eb49

alexcrichton added a commit to alexcrichton/rust that referenced this issue Sep 29, 2016

@alexcrichton
std: Stabilize and deprecate APIs for 1.13 
This commit is intended to be backported to the 1.13 branch, and works with the
following APIs:

Stabilized

* `i32::checked_abs`
* `i32::wrapping_abs`
* `i32::overflowing_abs`
* `RefCell::try_borrow`
* `RefCell::try_borrow_mut`
* `DefaultHasher`
* `DefaultHasher::new`
* `DefaultHasher::default`

Deprecated

* `BinaryHeap::push_pop`
* `BinaryHeap::replace`
* `SipHash13`
* `SipHash24`
* `SipHasher` - use `DefaultHasher` instead in the `std::collections::hash_map`
  module

Closes rust-lang#28147
Closes rust-lang#34767
Closes rust-lang#35057
Closes rust-lang#35070
c5209c3

alexcrichton added a commit to alexcrichton/rust that referenced this issue Sep 29, 2016

@alexcrichton
std: Stabilize and deprecate APIs for 1.13 
This commit is intended to be backported to the 1.13 branch, and works with the
following APIs:

Stabilized

* `i32::checked_abs`
* `i32::wrapping_abs`
* `i32::overflowing_abs`
* `RefCell::try_borrow`
* `RefCell::try_borrow_mut`
* `DefaultHasher`
* `DefaultHasher::new`
* `DefaultHasher::default`

Deprecated

* `BinaryHeap::push_pop`
* `BinaryHeap::replace`
* `SipHash13`
* `SipHash24`
* `SipHasher` - use `DefaultHasher` instead in the `std::collections::hash_map`
  module

Closes rust-lang#28147
Closes rust-lang#34767
Closes rust-lang#35057
Closes rust-lang#35070
0cdd570

alexcrichton added a commit to alexcrichton/rust that referenced this issue Sep 29, 2016

@alexcrichton
std: Stabilize and deprecate APIs for 1.13 
This commit is intended to be backported to the 1.13 branch, and works with the
following APIs:

Stabilized

* `i32::checked_abs`
* `i32::wrapping_abs`
* `i32::overflowing_abs`
* `RefCell::try_borrow`
* `RefCell::try_borrow_mut`
* `DefaultHasher`
* `DefaultHasher::new`
* `DefaultHasher::default`

Deprecated

* `BinaryHeap::push_pop`
* `BinaryHeap::replace`
* `SipHash13`
* `SipHash24`
* `SipHasher` - use `DefaultHasher` instead in the `std::collections::hash_map`
  module

Closes rust-lang#28147
Closes rust-lang#34767
Closes rust-lang#35057
Closes rust-lang#35070
546c052

bors added a commit that referenced this issue Sep 30, 2016

@bors
Auto merge of #36815 - alexcrichton:stabilize-1.13, r=aturon 
std: Stabilize and deprecate APIs for 1.13

This commit is intended to be backported to the 1.13 branch, and works with the
following APIs:

Stabilized

* `i32::checked_abs`
* `i32::wrapping_abs`
* `i32::overflowing_abs`
* `RefCell::try_borrow`
* `RefCell::try_borrow_mut`

Deprecated

* `BinaryHeap::push_pop`
* `BinaryHeap::replace`
* `SipHash13`
* `SipHash24`
* `SipHasher` - use `DefaultHasher` instead in the `std::collections::hash_map`
  module

Closes #28147
Closes #34767
Closes #35057
Closes #35070
ce57a05

alexcrichton added a commit to alexcrichton/rust that referenced this issue Sep 30, 2016

@alexcrichton
std: Stabilize and deprecate APIs for 1.13 
This commit is intended to be backported to the 1.13 branch, and works with the
following APIs:

Stabilized

* `i32::checked_abs`
* `i32::wrapping_abs`
* `i32::overflowing_abs`
* `RefCell::try_borrow`
* `RefCell::try_borrow_mut`
* `DefaultHasher`
* `DefaultHasher::new`
* `DefaultHasher::default`

Deprecated

* `BinaryHeap::push_pop`
* `BinaryHeap::replace`
* `SipHash13`
* `SipHash24`
* `SipHasher` - use `DefaultHasher` instead in the `std::collections::hash_map`
  module

Closes rust-lang#28147
Closes rust-lang#34767
Closes rust-lang#35057
Closes rust-lang#35070
7c86a2b

bors added a commit that referenced this issue Oct 1, 2016

@bors
Auto merge of #36815 - alexcrichton:stabilize-1.13, r=aturon 
std: Stabilize and deprecate APIs for 1.13

This commit is intended to be backported to the 1.13 branch, and works with the
following APIs:

Stabilized

* `i32::checked_abs`
* `i32::wrapping_abs`
* `i32::overflowing_abs`
* `RefCell::try_borrow`
* `RefCell::try_borrow_mut`

Deprecated

* `BinaryHeap::push_pop`
* `BinaryHeap::replace`
* `SipHash13`
* `SipHash24`
* `SipHasher` - use `DefaultHasher` instead in the `std::collections::hash_map`
  module

Closes #28147
Closes #34767
Closes #35057
Closes #35070
ec3fc8e

alexcrichton added a commit to alexcrichton/rust that referenced this issue Oct 3, 2016

@alexcrichton
std: Stabilize and deprecate APIs for 1.13 
This commit is intended to be backported to the 1.13 branch, and works with the
following APIs:

Stabilized

* `i32::checked_abs`
* `i32::wrapping_abs`
* `i32::overflowing_abs`
* `RefCell::try_borrow`
* `RefCell::try_borrow_mut`
* `DefaultHasher`
* `DefaultHasher::new`
* `DefaultHasher::default`

Deprecated

* `BinaryHeap::push_pop`
* `BinaryHeap::replace`
* `SipHash13`
* `SipHash24`
* `SipHasher` - use `DefaultHasher` instead in the `std::collections::hash_map`
  module

Closes rust-lang#28147
Closes rust-lang#34767
Closes rust-lang#35057
Closes rust-lang#35070
10c3134

bors added a commit that referenced this issue Oct 3, 2016

@bors
Auto merge of #36815 - alexcrichton:stabilize-1.13, r=aturon 
std: Stabilize and deprecate APIs for 1.13

This commit is intended to be backported to the 1.13 branch, and works with the
following APIs:

Stabilized

* `i32::checked_abs`
* `i32::wrapping_abs`
* `i32::overflowing_abs`
* `RefCell::try_borrow`
* `RefCell::try_borrow_mut`

Deprecated

* `BinaryHeap::push_pop`
* `BinaryHeap::replace`
* `SipHash13`
* `SipHash24`
* `SipHasher` - use `DefaultHasher` instead in the `std::collections::hash_map`
  module

Closes #28147
Closes #34767
Closes #35057
Closes #35070
7a26aec

@bors bors closed this in #36815 Oct 3, 2016

@SimonSapin

This comment has been minimized.

Sign in to view
Copy link
Contributor

SimonSapin commented Oct 10, 2016

The SipHasher::new_with_keys functionality got deprecated without replacement. This wasn’t discussed specifically, so it looks like to may have been unintentional.

I’d like libcore to provide non-deprecated API for this functionality: #37071

alexcrichton added a commit to alexcrichton/rust that referenced this issue Oct 10, 2016

@alexcrichton
std: Stabilize and deprecate APIs for 1.13 
This commit is intended to be backported to the 1.13 branch, and works with the
following APIs:

Stabilized

* `i32::checked_abs`
* `i32::wrapping_abs`
* `i32::overflowing_abs`
* `RefCell::try_borrow`
* `RefCell::try_borrow_mut`
* `DefaultHasher`
* `DefaultHasher::new`
* `DefaultHasher::default`

Deprecated

* `BinaryHeap::push_pop`
* `BinaryHeap::replace`
* `SipHash13`
* `SipHash24`
* `SipHasher` - use `DefaultHasher` instead in the `std::collections::hash_map`
  module

Closes rust-lang#28147
Closes rust-lang#34767
Closes rust-lang#35057
Closes rust-lang#35070
2d1feef
@jimblandy

This comment has been minimized.

Sign in to view
Copy link
Contributor

jimblandy commented Feb 16, 2017

While RandomState is currently implemented with SipHash-1-3, this will not necessarily continue to be the case in the future if, for example, a faster cryptographic hash is developed or security flaws are found in it. We don't want to be forced to keep these implementations around forever if that happens.

@sfackler, is the concern here that the library team doesn't want to keep around hashers that aren't currently used in std::collections or the like, just because they have been used in the past?

@chritchens chritchens referenced this issue Apr 27, 2017

Merged

Use DefaultHasher in place of the deprecated SipHasher #11

@eisterman

This comment has been minimized.

Sign in to view
Copy link

eisterman commented Mar 31, 2018

When the SipHasher13 will be removed and his method moved in DefaultHasher?
@SimonSapin

This comment has been minimized.

Sign in to view
Copy link
Contributor

SimonSapin commented Mar 31, 2018 •
edited

#49108 "removed" SipHasher13 from the documented public API of the standard library.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.