New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std: Stabilize and deprecate APIs for 1.13 #36815

Merged
merged 1 commit into from Oct 3, 2016

Conversation

Projects
None yet
7 participants
@alexcrichton
Member

alexcrichton commented Sep 29, 2016

This commit is intended to be backported to the 1.13 branch, and works with the
following APIs:

Stabilized

  • i32::checked_abs
  • i32::wrapping_abs
  • i32::overflowing_abs
  • RefCell::try_borrow
  • RefCell::try_borrow_mut

Deprecated

  • BinaryHeap::push_pop
  • BinaryHeap::replace
  • SipHash13
  • SipHash24
  • SipHasher - use DefaultHasher instead in the std::collections::hash_map
    module

Closes #28147
Closes #34767
Closes #35057
Closes #35070

@rust-highfive

This comment has been minimized.

Collaborator

rust-highfive commented Sep 29, 2016

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton alexcrichton force-pushed the alexcrichton:stabilize-1.13 branch 5 times, most recently from ba3cf9c to 1b3eb49 Sep 29, 2016

@aturon

This comment has been minimized.

Member

aturon commented Sep 29, 2016

r=me after fixing tidy failure

@bors

This comment has been minimized.

Contributor

bors commented Sep 29, 2016

☔️ The latest upstream changes (presumably #36818) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton alexcrichton force-pushed the alexcrichton:stabilize-1.13 branch 2 times, most recently from c5209c3 to 0cdd570 Sep 29, 2016

@alexcrichton

This comment has been minimized.

Member

alexcrichton commented Sep 29, 2016

@bors: r=aturon

@bors

This comment has been minimized.

Contributor

bors commented Sep 29, 2016

📌 Commit 0cdd570 has been approved by aturon

@alexcrichton alexcrichton force-pushed the alexcrichton:stabilize-1.13 branch from 0cdd570 to 546c052 Sep 29, 2016

@alexcrichton

This comment has been minimized.

Member

alexcrichton commented Sep 29, 2016

@bors: r=aturon

@bors

This comment has been minimized.

Contributor

bors commented Sep 29, 2016

📌 Commit 546c052 has been approved by aturon

@bors

This comment has been minimized.

Contributor

bors commented Sep 30, 2016

⌛️ Testing commit 546c052 with merge ce57a05...

bors added a commit that referenced this pull request Sep 30, 2016

Auto merge of #36815 - alexcrichton:stabilize-1.13, r=aturon
std: Stabilize and deprecate APIs for 1.13

This commit is intended to be backported to the 1.13 branch, and works with the
following APIs:

Stabilized

* `i32::checked_abs`
* `i32::wrapping_abs`
* `i32::overflowing_abs`
* `RefCell::try_borrow`
* `RefCell::try_borrow_mut`

Deprecated

* `BinaryHeap::push_pop`
* `BinaryHeap::replace`
* `SipHash13`
* `SipHash24`
* `SipHasher` - use `DefaultHasher` instead in the `std::collections::hash_map`
  module

Closes #28147
Closes #34767
Closes #35057
Closes #35070
@bors

This comment has been minimized.

Contributor

bors commented Sep 30, 2016

💔 Test failed - auto-win-msvc-64-cargotest

@sfackler

This comment has been minimized.

Member

sfackler commented Sep 30, 2016

/me shakes fist at #[deny(warnings)]

alexcrichton added a commit to alexcrichton/cargo that referenced this pull request Sep 30, 2016

Allow deprecated use of SipHasher
This type is being deprecated in rust-lang/rust#36815, so allow use of the
deprecated type for now. We can fix this later once new APIs have landed.

bors added a commit to rust-lang/cargo that referenced this pull request Sep 30, 2016

Auto merge of #3142 - alexcrichton:siphash, r=alexcrichton
Allow deprecated use of SipHasher

This type is being deprecated in rust-lang/rust#36815, so allow use of the
deprecated type for now. We can fix this later once new APIs have landed.

@alexcrichton alexcrichton force-pushed the alexcrichton:stabilize-1.13 branch from 546c052 to 7c86a2b Sep 30, 2016

@alexcrichton

This comment has been minimized.

Member

alexcrichton commented Sep 30, 2016

@bors: r=aturon

@bors

This comment has been minimized.

Contributor

bors commented Sep 30, 2016

📌 Commit 7c86a2b has been approved by aturon

@brson brson added the relnotes label Sep 30, 2016

@bors

This comment has been minimized.

Contributor

bors commented Oct 1, 2016

⌛️ Testing commit 7c86a2b with merge ec3fc8e...

bors added a commit that referenced this pull request Oct 1, 2016

Auto merge of #36815 - alexcrichton:stabilize-1.13, r=aturon
std: Stabilize and deprecate APIs for 1.13

This commit is intended to be backported to the 1.13 branch, and works with the
following APIs:

Stabilized

* `i32::checked_abs`
* `i32::wrapping_abs`
* `i32::overflowing_abs`
* `RefCell::try_borrow`
* `RefCell::try_borrow_mut`

Deprecated

* `BinaryHeap::push_pop`
* `BinaryHeap::replace`
* `SipHash13`
* `SipHash24`
* `SipHasher` - use `DefaultHasher` instead in the `std::collections::hash_map`
  module

Closes #28147
Closes #34767
Closes #35057
Closes #35070
@bors

This comment has been minimized.

Contributor

bors commented Oct 1, 2016

💔 Test failed - auto-linux-musl-64-opt

std: Stabilize and deprecate APIs for 1.13
This commit is intended to be backported to the 1.13 branch, and works with the
following APIs:

Stabilized

* `i32::checked_abs`
* `i32::wrapping_abs`
* `i32::overflowing_abs`
* `RefCell::try_borrow`
* `RefCell::try_borrow_mut`
* `DefaultHasher`
* `DefaultHasher::new`
* `DefaultHasher::default`

Deprecated

* `BinaryHeap::push_pop`
* `BinaryHeap::replace`
* `SipHash13`
* `SipHash24`
* `SipHasher` - use `DefaultHasher` instead in the `std::collections::hash_map`
  module

Closes #28147
Closes #34767
Closes #35057
Closes #35070

@alexcrichton alexcrichton force-pushed the alexcrichton:stabilize-1.13 branch from 7c86a2b to 10c3134 Oct 3, 2016

@alexcrichton

This comment has been minimized.

Member

alexcrichton commented Oct 3, 2016

@bors: r=aturon

@bors

This comment has been minimized.

Contributor

bors commented Oct 3, 2016

📌 Commit 10c3134 has been approved by aturon

@bors

This comment has been minimized.

Contributor

bors commented Oct 3, 2016

⌛️ Testing commit 10c3134 with merge 7a26aec...

bors added a commit that referenced this pull request Oct 3, 2016

Auto merge of #36815 - alexcrichton:stabilize-1.13, r=aturon
std: Stabilize and deprecate APIs for 1.13

This commit is intended to be backported to the 1.13 branch, and works with the
following APIs:

Stabilized

* `i32::checked_abs`
* `i32::wrapping_abs`
* `i32::overflowing_abs`
* `RefCell::try_borrow`
* `RefCell::try_borrow_mut`

Deprecated

* `BinaryHeap::push_pop`
* `BinaryHeap::replace`
* `SipHash13`
* `SipHash24`
* `SipHasher` - use `DefaultHasher` instead in the `std::collections::hash_map`
  module

Closes #28147
Closes #34767
Closes #35057
Closes #35070

@bors bors merged commit 10c3134 into rust-lang:master Oct 3, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@alexcrichton alexcrichton deleted the alexcrichton:stabilize-1.13 branch Oct 6, 2016

@brson brson removed the beta-nominated label Oct 11, 2016

@dead10ck

This comment has been minimized.

dead10ck commented Feb 19, 2017

Is there any plan to split SipHasher into its own crate, for those who specifically want a stable SipHash hasher?

@sfackler

This comment has been minimized.

Member

sfackler commented Feb 19, 2017

@dead10ck

This comment has been minimized.

dead10ck commented Feb 19, 2017

I guess I should clarify: since users of SipHasher have, so far, been using an officially published and maintained SipHash implementation, is the Rust team going to publish and maintain an official SipHash crate in the rust-lang GitHub org? Or is the plan just to let the community fill the gap?

@sfackler

This comment has been minimized.

Member

sfackler commented Feb 19, 2017

Is there anything lacking/problematic with https://crates.io/crates/siphasher?

@dead10ck

This comment has been minimized.

dead10ck commented Feb 19, 2017

I don't know; I haven't tried it. I just need a stable SipHash implementation, and I'd just like to know how to proceed. If there's going to be an official SipHash crate in the relatively near future, then I'd rather wait for that, but if not, then I can try out the available community crates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment