Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E0166 needs to be updated to new format #35271

Closed
sophiajt opened this issue Aug 3, 2016 · 1 comment
Closed

E0166 needs to be updated to new format #35271

sophiajt opened this issue Aug 3, 2016 · 1 comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@sophiajt
Copy link
Contributor

sophiajt commented Aug 3, 2016

From: src/test/compile-fail/E0166.rs

Error E0166 needs a span_label, updating it from:

error[E0166]: `return` in a function declared as diverging
  --> src/test/compile-fail/E0166.rs:11:17
   |
11 | fn foo() -> ! { return; } //~ ERROR E0166
   |                 ^^^^^^

To:

error[E0166]: `return` in a function declared as diverging
  --> src/test/compile-fail/E0166.rs:11:17
   |
11 | fn foo() -> ! { return; } //~ ERROR E0166
   |                 ^^^^^^ diverging function cannot return
@sophiajt sophiajt added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-diagnostics Area: Messages for errors, warnings, and lints E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Aug 3, 2016
@Roybie
Copy link
Contributor

Roybie commented Aug 4, 2016

Taking this one

sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 5, 2016
…mat, r=GuillaumeGomez

Update error message for E0166

Fixes rust-lang#35271 as part of rust-lang#35233.

r? @jonathandturner
eddyb added a commit to eddyb/rust that referenced this issue Aug 6, 2016
…mat, r=GuillaumeGomez

Update error message for E0166

Fixes rust-lang#35271 as part of rust-lang#35233.

r? @jonathandturner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Development

No branches or pull requests

2 participants