Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor librustc_codegen_llvm for multiple codegen backends. #45274

Open
eddyb opened this Issue Oct 14, 2017 · 0 comments

Comments

Assignees

@eddyb eddyb

Labels
C-feature-request
Projects
None yet
Milestone
No milestone
2 participants
@eddyb @kennytm
@eddyb
Copy link
Member

eddyb commented Oct 14, 2017 •
edited

[#50615] Rename librustc_trans to librustc_codegen_llvm.
Make rustc_driver either able to choose codegen backends, or even better, pass rustc_codegen_llvm to rustc_driver from rustc-main.
See also #45226.

Possible refactoring steps:

  • remove SharedCrateContext, use TyCtxt
  • rename (Local)CrateContext to CodegenContext, remove accessor methods
  • [#52461] merge librustc_llvm into librustc_codegen_llvm
    • pass ValueRef as &'ll Value instead, encode LLVM lifetimes in FFI signatures
    • use this technique for C++ objects that borrow others: #43467 (comment)
  • use this technique for the DI* inheritance hierarchy: #43467 (comment)
  • use &'ll Module<'ll>, &'ll Value<'ll>, &'ll Type<'ll> etc. to correctly model lifetime relationships (without an invariant lifetime parameter, very little is actually enforced)
  • refer to cranelift and llvm2cranelift for common Cranelift/LLVM builder APIs
    • [#55627] common tools used by SSA backends could be placed in rustc_codegen_ssa
    • refactor rustc_codegen_ssa APIs to match Cranelift, leave LLVM second-class
      • unaddressed comments from #55627 may be relevant here
  • split the metadata, "optimize + generate machine code" (should it be called "binemit"?) and linking components, out of rustc_codegen_ssa

@kennytm kennytm added the C-feature-request label Oct 14, 2017

@rkruppe rkruppe referenced this issue Oct 19, 2017

Closed

Merge (most of) rustc_llvm into rustc_trans #41699

@bjorn3 bjorn3 referenced this issue Nov 1, 2017

Closed

[driver breaking] Rename rustc_trans to rustc_codegen_llvm and allow runtime switching between trans backends #45677

@eddyb eddyb self-assigned this Nov 8, 2017

@eddyb eddyb referenced this issue Dec 18, 2017

Closed

Implement shipping a per-target LLVM backend #46819

@eddyb eddyb referenced this issue Jan 23, 2018

Merged

rustc: Load the `rustc_trans` crate at runtime #47671

@irinagpopa irinagpopa referenced this issue May 10, 2018

Merged

Rename trans to codegen everywhere. #50615

bors added a commit that referenced this issue May 14, 2018

@bors
Auto merge of #50615 - irinagpopa:rename-trans, r=nikomatsakis 
Rename trans to codegen everywhere.

Part of #45274.
Loading status checks…
dffc588

bors added a commit that referenced this issue May 17, 2018

@bors
Auto merge of #50615 - irinagpopa:rename-trans, r=nikomatsakis 
Rename trans to codegen everywhere.

Part of #45274.
Loading status checks…
dbd10f8

@eddyb eddyb referenced this issue Jun 15, 2018

Closed

Build `librustc_llvm` as a dylib, and install it as part of the private rustc crates. #50404

@eddyb eddyb changed the title Rename librustc_trans to librustc_codegen_llvm. Refactor librustc_codegen_llvm for multiple codegen backends. Jul 13, 2018

@eddyb eddyb referenced this issue Jul 13, 2018

Closed

Move LocalAnalyzer to rustc_mir::ssa_analyze #52208

@irinagpopa irinagpopa referenced this issue Jul 17, 2018

Merged

rustc_codegen_llvm: use safe references for LLVM FFI types. #52461

bors added a commit that referenced this issue Jul 18, 2018

@bors
Auto merge of #52461 - irinagpopa:safe-llvm, r=nikomatsakis 
 rustc_codegen_llvm: use safe references for LLVM FFI types.

Part of #45274.
Loading status checks…
e1c7813

bors added a commit that referenced this issue Jul 18, 2018

@bors
Auto merge of #52461 - irinagpopa:safe-llvm, r=nikomatsakis 
 rustc_codegen_llvm: use safe references for LLVM FFI types.

Part of #45274.
Loading status checks…
8c34f7e

bors added a commit that referenced this issue Jul 18, 2018

@bors
Auto merge of #52461 - irinagpopa:safe-llvm, r=nikomatsakis 
 rustc_codegen_llvm: use safe references for LLVM FFI types.

Part of #45274.
Loading status checks…
bc8fadd

bors added a commit that referenced this issue Jul 18, 2018

@bors
Auto merge of #52461 - irinagpopa:safe-llvm, r=nikomatsakis 
 rustc_codegen_llvm: use safe references for LLVM FFI types.

Part of #45274.
Loading status checks…
6644aaf

bors added a commit that referenced this issue Jul 19, 2018

@bors
Auto merge of #52461 - irinagpopa:safe-llvm, r=nikomatsakis 
 rustc_codegen_llvm: use safe references for LLVM FFI types.

Part of #45274.
Loading status checks…
d41e942

bors added a commit that referenced this issue Jul 30, 2018

@bors
Auto merge of #52461 - irinagpopa:safe-llvm, r=nikomatsakis 
 rustc_codegen_llvm: use safe references for LLVM FFI types.

Part of #45274.
Loading status checks…
3140e88

bors added a commit that referenced this issue Jul 31, 2018

@bors
Auto merge of #52461 - irinagpopa:safe-llvm, r=nikomatsakis 
 rustc_codegen_llvm: use safe references for LLVM FFI types.

Part of #45274.
Loading status checks…
f898179

@irinagpopa irinagpopa referenced this issue Aug 2, 2018

Closed

rustc_codegen_llvm: begin generalizing over backend values. #52987

@denismerigoux denismerigoux referenced this issue Sep 6, 2018

Closed

rustc_codegen_llvm: traitification of LLVM-specific CodegenCx and Builder methods #54012

bors added a commit that referenced this issue Sep 7, 2018

@bors
Auto merge of #54012 - denismerigoux:cg-llvm-gen, r=<try> 
rustc_codegen_llvm: traitification of LLVM-specific CodegenCx and Builder methods

This PR is the continuation of #52461 in the grand plan of #45274 to allow for multiple codegen backends. A first attempt at this was #52987 but since @irinagpopa is no longer working on it I'm taking ownership of the PR.

The changes are refactoring only and do not affect the logic of the code. Performance should not be impacted since all parametrization is done with generics (no trait objects).

The `librustc_codegen_llvm` crate now contains a new folder `interfaces` that describes with traits part of how the compiler interfaces with LLVM during codegen. `CodegenCx` and `Builder` implement those traits.

Many things are still missing. All the calls to LLVM are not yet under a trait, and later LLVM-agnostic code should be parametrized.
Loading status checks…
12c6a75

bors added a commit that referenced this issue Oct 9, 2018

@bors
Auto merge of #54012 - denismerigoux:cg-llvm-gen, r=<try> 
rustc_codegen_llvm: traitification of LLVM-specific CodegenCx and Builder methods

This PR is the continuation of #52461 in the grand plan of #45274 to allow for multiple codegen backends. A first attempt at this was #52987 but since @irinagpopa is no longer working on it I'm taking ownership of the PR.

The changes are refactoring only and do not affect the logic of the code. Performance should not be impacted since all parametrization is done with generics (no trait objects).

The `librustc_codegen_llvm` crate now contains a new folder `interfaces` that describes with traits part of how the compiler interfaces with LLVM during codegen. `CodegenCx` and `Builder` implement those traits.

Many things are still missing. All the calls to LLVM are not yet under a trait, and later LLVM-agnostic code should be parametrized.
Loading status checks…
63cfaff

bors added a commit that referenced this issue Oct 10, 2018

@bors
Auto merge of #54012 - denismerigoux:cg-llvm-gen, r=<try> 
rustc_codegen_llvm: traitification of LLVM-specific CodegenCx and Builder methods

This PR is the continuation of #52461 in the grand plan of #45274 to allow for multiple codegen backends. A first attempt at this was #52987 but since @irinagpopa is no longer working on it I'm taking ownership of the PR.

The changes are refactoring only and do not affect the logic of the code. Performance should not be impacted since all parametrization is done with generics (no trait objects).

The `librustc_codegen_llvm` crate now contains a new folder `interfaces` that describes with traits part of how the compiler interfaces with LLVM during codegen. `CodegenCx` and `Builder` implement those traits.

Many things are still missing. All the calls to LLVM are not yet under a trait, and later LLVM-agnostic code should be parametrized.
Loading status checks…
5b23dbc

@sunfishcode sunfishcode referenced this issue Nov 2, 2018

Merged

rustc_codegen_llvm: traitification of LLVM-specific CodegenCx and Builder methods #55627

bors added a commit that referenced this issue Nov 16, 2018

@bors
Auto merge of #55627 - sunfishcode:cg-llvm-gen, r=<try> 
rustc_codegen_llvm: traitification of LLVM-specific CodegenCx and Builder methods

This PR is the continuation of #54012 and earlier PRs, in the grand plan of #45274 to allow for multiple codegen backends.

High-level summary: interpose a set of traits between Rust's codegen logic and the LLVM APIs, allowing another backend to implement the traits and share most of the codegen logic. These traits are currently somewhat LLVM-specific, but once this refactoring is in place, they can evolve to be more general.

See [this README](https://github.com/rust-lang/rust/blob/756f84d7cef90b7364ae88ca707e59670dde4c92/src/librustc_codegen_ssa/README.md) for a writeup on the current trait organization.
Loading status checks…
dd5853b

bors added a commit that referenced this issue Nov 17, 2018

@bors
Auto merge of #55627 - sunfishcode:cg-llvm-gen, r=nikomatsakis 
rustc_codegen_llvm: traitification of LLVM-specific CodegenCx and Builder methods

This PR is the continuation of #54012 and earlier PRs, in the grand plan of #45274 to allow for multiple codegen backends.

High-level summary: interpose a set of traits between Rust's codegen logic and the LLVM APIs, allowing another backend to implement the traits and share most of the codegen logic. These traits are currently somewhat LLVM-specific, but once this refactoring is in place, they can evolve to be more general.

See [this README](https://github.com/rust-lang/rust/blob/756f84d7cef90b7364ae88ca707e59670dde4c92/src/librustc_codegen_ssa/README.md) for a writeup on the current trait organization.
Loading status checks…
c5b7d98

bors added a commit that referenced this issue Nov 17, 2018

@bors
Auto merge of #55627 - sunfishcode:cg-llvm-gen, r=nikomatsakis 
rustc_codegen_llvm: traitification of LLVM-specific CodegenCx and Builder methods

This PR is the continuation of #54012 and earlier PRs, in the grand plan of #45274 to allow for multiple codegen backends.

High-level summary: interpose a set of traits between Rust's codegen logic and the LLVM APIs, allowing another backend to implement the traits and share most of the codegen logic. These traits are currently somewhat LLVM-specific, but once this refactoring is in place, they can evolve to be more general.

See [this README](https://github.com/rust-lang/rust/blob/756f84d7cef90b7364ae88ca707e59670dde4c92/src/librustc_codegen_ssa/README.md) for a writeup on the current trait organization.
Loading status checks…
f6e9485
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.