rls no longer builds after rust-lang/rust#56732
#59060
Assignees
Labels
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Comments
rust-highfive
added
I-nominated
T-compiler
|
@Zoxc https://github.com/rust-dev-tools/rls-rustc/pull/11/files this should be a good starting point, right? (We now moved it under https://github.com/rust-lang/rls repo) |
bors
added a commit
that referenced
this issue
Mar 11, 2019
Update RLS and Clippy due to #56732 (rustc_interface crate) Closes #59060. In addition to plain submodule bumps, this also contains update to rls-rustc. The in-tree, from the RLS monorepo, version is used instead of the crates.io one (@nrc I think we might stop publishing `rls-rustc` altogether, right? It's only there to work around passing `-Zsave-analysis` to stable `rustc` and meant to be used only by RLS, IIRC). @Zoxc also due to how we need to access the expanded AST still from the RLS side in order to pass save analysis data in-memory, I delayed the AST drop after the `after_analysis` callback if the `-Zsave-analysis` is passed. It'd be also good if you could take a look at the changes inside the `rls` and `rls-rustc`: rust-lang/rls@6a1b5a9...6840dd6. The `rls-rustc` is based on your [PR](rust-dev-tools/rls-rustc#11) but I also had to change some bits in the RLS itself. r? @Zoxc / @Manishearth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello, this is your friendly neighborhood mergebot.
After merging PR #56732, I observed that the tool rls no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rls is needed to fix the fallout.
cc @Zoxc, do you think you would have time to do the follow-up work?
If so, that would be great!
cc @oli-obk, the PR reviewer, and @rust-lang/compiler -- nominating for prioritization.
The text was updated successfully, but these errors were encountered: