Update RLS and Clippy due to #56732 (rustc_interface crate) #59073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rust-highfive
added
the
S-waiting-on-review
|
r=me for the clippy update |
|
The changes look good to me, but I wasn't expecting RLS to do code generation. @bors r+ |
|
📌 Commit 9a6a269 has been approved by |
bors
added
S-waiting-on-bors
|
I'll bump the prio due to lockfile and tools changes: @bors p=1 |
Yes. Passing |
bors
added a commit
that referenced
this pull request
Mar 11, 2019
Update RLS and Clippy due to #56732 (rustc_interface crate) Closes #59060. In addition to plain submodule bumps, this also contains update to rls-rustc. The in-tree, from the RLS monorepo, version is used instead of the crates.io one (@nrc I think we might stop publishing `rls-rustc` altogether, right? It's only there to work around passing `-Zsave-analysis` to stable `rustc` and meant to be used only by RLS, IIRC). @Zoxc also due to how we need to access the expanded AST still from the RLS side in order to pass save analysis data in-memory, I delayed the AST drop after the `after_analysis` callback if the `-Zsave-analysis` is passed. It'd be also good if you could take a look at the changes inside the `rls` and `rls-rustc`: rust-lang/rls@6a1b5a9...6840dd6. The `rls-rustc` is based on your [PR](rust-dev-tools/rls-rustc#11) but I also had to change some bits in the RLS itself. r? @Zoxc / @Manishearth
|
☀️ Test successful - checks-travis, status-appveyor |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Mar 11, 2019
Tested on commit rust-lang/rust@de5c3c4. Direct link to PR: <rust-lang/rust#59073> 🎉 rls on windows: build-fail → test-pass (cc @nrc @Xanewok, @rust-lang/infra). 🎉 rls on linux: build-fail → test-pass (cc @nrc @Xanewok, @rust-lang/infra).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #59060.
In addition to plain submodule bumps, this also contains update to rls-rustc. The in-tree, from the RLS monorepo, version is used instead of the crates.io one (@nrc I think we might stop publishing
rls-rustcaltogether, right? It's only there to work around passing-Zsave-analysisto stablerustcand meant to be used only by RLS, IIRC).@Zoxc also due to how we need to access the expanded AST still from the RLS side in order to pass save analysis data in-memory, I delayed the AST drop after the
after_analysiscallback if the-Zsave-analysisis passed.It'd be also good if you could take a look at the changes inside the
rlsandrls-rustc: rust-lang/rls@6a1b5a9...6840dd6. Therls-rustcis based on your PR but I also had to change some bits in the RLS itself.r? @Zoxc / @Manishearth